From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12648 invoked by alias); 26 Apr 2013 11:19:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12638 invoked by uid 89); 26 Apr 2013 11:19:31 -0000 X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from toccata.ens-lyon.fr (HELO toccata.ens-lyon.org) (140.77.166.68) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 11:19:30 +0000 Received: from localhost (localhost [127.0.0.1]) by toccata.ens-lyon.org (Postfix) with ESMTP id 858698408E; Fri, 26 Apr 2013 13:19:28 +0200 (CEST) Received: from toccata.ens-lyon.org ([127.0.0.1]) by localhost (toccata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NH3qmEXa+n+I; Fri, 26 Apr 2013 13:19:28 +0200 (CEST) Received: from type.ipv6 (youpi.is-a-geek.org [80.67.176.89]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by toccata.ens-lyon.org (Postfix) with ESMTPSA id 358A98408B; Fri, 26 Apr 2013 13:19:28 +0200 (CEST) Received: from samy by type.ipv6 with local (Exim 4.80) (envelope-from ) id 1UVggY-0004wL-NN; Fri, 26 Apr 2013 13:19:26 +0200 Date: Fri, 26 Apr 2013 17:50:00 -0000 From: Samuel Thibault To: Joel Brobecker Cc: gdb-patches@sourceware.org, thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCH,HURD] Fix reading core Message-ID: <20130426111926.GX5825@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org, thomas@schwinge.name, bug-hurd@gnu.org References: <20130211020109.GK5926@type.youpi.perso.aquilenet.fr> <20130409234117.GC24389@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130409234117.GC24389@adacore.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-SW-Source: 2013-04/txt/msg00807.txt.bz2 Joel Brobecker, le Tue 09 Apr 2013 16:41:17 -0700, a écrit : > > The i386 GNU/Hurd ELF core format actually follows the uaccess gregset_t > > array format, not the Mach thread state format. This fixes gdb reading > > it. > > > > * gdb/i386gnu-nat.c (CREG_OFFSET): New macro. > > (creg_offset): New array. > > (CREG_ADDR): Use creg_offset instead of reg_offset. > > Did anyone review this? I don't know GNU/Hurd, but the patch looks > very plausible. > > Do you have write access to the GDB repository? I don't. > If not, do you have copyright assignment papers on file? It's on file now. Samuel