From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [commit+7.6] testsuite: Add more valgrind kills on cleanup
Date: Mon, 18 Mar 2013 01:52:00 -0000 [thread overview]
Message-ID: <20130317204746.GA18446@host2.jankratochvil.net> (raw)
Hi,
I have already checked in a similar stale valgrind cleanup:
[patch] testsuite: valgrind-infcall.exp: explicit kill
http://sourceware.org/ml/gdb-patches/2013-02/msg00459.html
Message-ID: <20130218154552.GA16416@host2.jankratochvil.net>
I have found today that it still does not solve everything, the missed case(s)
are patched below.
Checked in:
http://sourceware.org/ml/gdb-cvs/2013-03/msg00156.html
and also for 7.6 as this is a very safe patch:
http://sourceware.org/ml/gdb-cvs/2013-03/msg00157.html
As Tom asked off-list before this case was not caught by 'orphanripper'
http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-orphanripper.c
present in Fedora GDB as this tool got stale waiting on fd EOF with stuck
valgrind had this fd open for writing. This was exactly the reason why
I wrote 'orphanripper' and its SIGCHLD handling should have caught that, I do
not yet understand why 'orphanripper' failed in this case.
Jan
http://sourceware.org/ml/gdb-cvs/2013-03/msg00156.html
--- src/gdb/testsuite/ChangeLog 2013/03/15 17:10:43 1.3588
+++ src/gdb/testsuite/ChangeLog 2013/03/17 20:37:30 1.3589
@@ -1,3 +1,10 @@
+2013-03-17 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/valgrind-infcall.exp
+ (continue #$continue_count) <remote connection closed>
+ (continue #$continue_count) <valgrind vgdb has terminated>: Add kill of
+ $valgrind_pid.
+
2013-03-15 Tom Tromey <tromey@redhat.com>
* gdb.cp/overload.cc (intintfunc): New.
--- src/gdb/testsuite/gdb.base/valgrind-infcall.exp 2013/02/27 18:46:52 1.7
+++ src/gdb/testsuite/gdb.base/valgrind-infcall.exp 2013/03/17 20:37:32 1.8
@@ -101,10 +101,14 @@
}
-re "Remote connection closed.*\r\n$gdb_prompt $" {
fail "$test (remote connection closed)"
+ # Only if valgrind got stuck.
+ remote_exec host "kill -9 ${valgrind_pid}"
return -1
}
-re "The program is not being run\\.\r\n$gdb_prompt $" {
fail "$test (valgrind vgdb has terminated)"
+ # Only if valgrind got stuck.
+ remote_exec host "kill -9 ${valgrind_pid}"
return -1
}
-re "\r\n$gdb_prompt $" {
next reply other threads:[~2013-03-17 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 1:52 Jan Kratochvil [this message]
2013-03-18 9:21 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317204746.GA18446@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox