From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18894 invoked by alias); 17 Mar 2013 20:48:07 -0000 Received: (qmail 18870 invoked by uid 22791); 17 Mar 2013 20:48:03 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_VG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 17 Mar 2013 20:47:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2HKlprw029991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 17 Mar 2013 16:47:51 -0400 Received: from host2.jankratochvil.net (ovpn-116-42.ams2.redhat.com [10.36.116.42]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2HKllfA011316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Sun, 17 Mar 2013 16:47:50 -0400 Date: Mon, 18 Mar 2013 01:52:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [commit+7.6] testsuite: Add more valgrind kills on cleanup Message-ID: <20130317204746.GA18446@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00704.txt.bz2 Hi, I have already checked in a similar stale valgrind cleanup: [patch] testsuite: valgrind-infcall.exp: explicit kill http://sourceware.org/ml/gdb-patches/2013-02/msg00459.html Message-ID: <20130218154552.GA16416@host2.jankratochvil.net> I have found today that it still does not solve everything, the missed case(s) are patched below. Checked in: http://sourceware.org/ml/gdb-cvs/2013-03/msg00156.html and also for 7.6 as this is a very safe patch: http://sourceware.org/ml/gdb-cvs/2013-03/msg00157.html As Tom asked off-list before this case was not caught by 'orphanripper' http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-orphanripper.c present in Fedora GDB as this tool got stale waiting on fd EOF with stuck valgrind had this fd open for writing. This was exactly the reason why I wrote 'orphanripper' and its SIGCHLD handling should have caught that, I do not yet understand why 'orphanripper' failed in this case. Jan http://sourceware.org/ml/gdb-cvs/2013-03/msg00156.html --- src/gdb/testsuite/ChangeLog 2013/03/15 17:10:43 1.3588 +++ src/gdb/testsuite/ChangeLog 2013/03/17 20:37:30 1.3589 @@ -1,3 +1,10 @@ +2013-03-17 Jan Kratochvil + + * gdb.base/valgrind-infcall.exp + (continue #$continue_count) + (continue #$continue_count) : Add kill of + $valgrind_pid. + 2013-03-15 Tom Tromey * gdb.cp/overload.cc (intintfunc): New. --- src/gdb/testsuite/gdb.base/valgrind-infcall.exp 2013/02/27 18:46:52 1.7 +++ src/gdb/testsuite/gdb.base/valgrind-infcall.exp 2013/03/17 20:37:32 1.8 @@ -101,10 +101,14 @@ } -re "Remote connection closed.*\r\n$gdb_prompt $" { fail "$test (remote connection closed)" + # Only if valgrind got stuck. + remote_exec host "kill -9 ${valgrind_pid}" return -1 } -re "The program is not being run\\.\r\n$gdb_prompt $" { fail "$test (valgrind vgdb has terminated)" + # Only if valgrind got stuck. + remote_exec host "kill -9 ${valgrind_pid}" return -1 } -re "\r\n$gdb_prompt $" {