From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, "Metzger,
Markus T" <markus.t.metzger@intel.com>
Subject: Re: [patch] Fix remote.c incorrectly using pop_target (wrt btrace)
Date: Mon, 11 Mar 2013 17:46:00 -0000 [thread overview]
Message-ID: <20130311174600.GG3264@adacore.com> (raw)
In-Reply-To: <20130311172836.GA22575@host2.jankratochvil.net>
> I would like to get it checked in for 7.6 is it is some sort of regression
> from btrace.
Agreed on getting this fixed before 7.6 gets released. I propose
we still go ahead with the branch tomorrow, and just port the fix
to the branch as soon as approved.
> gdb/
> 2013-03-11 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * remote.c (remote_unpush_target): New function.
> (remote_open_1): Remove two pop_target calls, update one comment, add
> comment to target_preopen call. Replace pop_target call by
> remote_unpush_target call.
> (interrupt_query, readchar, getpkt_or_notif_sane_1): Replace
> pop_target calls by remote_unpush_target calls.
--
Joel
next prev parent reply other threads:[~2013-03-11 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 17:29 Jan Kratochvil
2013-03-11 17:46 ` Joel Brobecker [this message]
2013-03-12 10:05 ` Yao Qi
2013-03-15 22:29 ` Jan Kratochvil
2013-03-18 2:09 ` Yao Qi
2013-03-22 19:28 ` Pedro Alves
2013-03-22 20:31 ` [commit+7.6] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311174600.GG3264@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox