From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23832 invoked by alias); 11 Mar 2013 17:46:16 -0000 Received: (qmail 23823 invoked by uid 22791); 11 Mar 2013 17:46:14 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 17:46:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3D97C2E695; Mon, 11 Mar 2013 13:46:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HdXpD5lrNj97; Mon, 11 Mar 2013 13:46:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ED0DD2E3CF; Mon, 11 Mar 2013 13:46:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2B46FC15EA; Mon, 11 Mar 2013 13:46:00 -0400 (EDT) Date: Mon, 11 Mar 2013 17:46:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, "Metzger, Markus T" Subject: Re: [patch] Fix remote.c incorrectly using pop_target (wrt btrace) Message-ID: <20130311174600.GG3264@adacore.com> References: <20130311172836.GA22575@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130311172836.GA22575@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00478.txt.bz2 > I would like to get it checked in for 7.6 is it is some sort of regression > from btrace. Agreed on getting this fixed before 7.6 gets released. I propose we still go ahead with the branch tomorrow, and just port the fix to the branch as soon as approved. > gdb/ > 2013-03-11 Jan Kratochvil > > * remote.c (remote_unpush_target): New function. > (remote_open_1): Remove two pop_target calls, update one comment, add > comment to target_preopen call. Replace pop_target call by > remote_unpush_target call. > (interrupt_query, readchar, getpkt_or_notif_sane_1): Replace > pop_target calls by remote_unpush_target calls. -- Joel