New target: x86_64-pc-cygwin

New target: x86_64-pc-cygwin

[Corinna Vinschen]

Hi guys,

now that the binutils patches are applied, I'd like to add the new
x86_64-pc-cygwin target to GDB.  What's still missing are the GCC
patches, but they will have to wait for the next GCC stage1.

Ok to apply?


Thanks,
Corinna


	* configure.host: Add x86_64-*-cygwin* as host.
	* configure.tgt: Add x86_64-*-cygwin* as target.
	* config/i386/cygwin64.mh: New file.
	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.


Index: configure.host
===================================================================
RCS file: /cvs/src/src/gdb/configure.host,v
retrieving revision 1.109
diff -u -p -r1.109 configure.host
--- configure.host	8 Feb 2013 09:00:34 -0000	1.109
+++ configure.host	5 Mar 2013 11:58:56 -0000
@@ -182,6 +182,7 @@ x86_64-*-openbsd*)	gdb_host=obsd64 ;;
 x86_64-*-mingw*)        gdb_host=mingw64
 			gdb_host_obs=mingw-hdep.o
 			;;
+x86_64-*-cygwin*)	gdb_host=cygwin64 ;;
 m32r*-*-linux*)          gdb_host=linux ;;
 
 xtensa*-*-linux*)	gdb_host=linux ;;
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.270
diff -u -p -r1.270 configure.tgt
--- configure.tgt	27 Feb 2013 14:49:15 -0000	1.270
+++ configure.tgt	5 Mar 2013 11:58:56 -0000
@@ -652,7 +652,7 @@ x86_64-*-freebsd* | x86_64-*-kfreebsd*-g
 			i387-tdep.o i386bsd-tdep.o i386fbsd-tdep.o \
 			bsd-uthread.o solib-svr4.o"
 	;;
-x86_64-*-mingw*)
+x86_64-*-mingw* | x86_64-*-cygwin*)
         # Target: MingW/amd64
 	gdb_target_obs="amd64-tdep.o amd64-windows-tdep.o \
                         i386-tdep.o i386-cygwin-tdep.o i387-tdep.o \
Index: config/i386/cygwin64.mh
===================================================================
RCS file: config/i386/cygwin64.mh
diff -N config/i386/cygwin64.mh
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ config/i386/cygwin64.mh	5 Mar 2013 11:58:56 -0000
@@ -0,0 +1 @@
+NATDEPFILES= i386-nat.o windows-nat.o amd64-windows-nat.o
Index: gdbserver/configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.72
diff -u -p -r1.72 configure.srv
--- gdbserver/configure.srv	27 Feb 2013 14:58:18 -0000	1.72
+++ gdbserver/configure.srv	5 Mar 2013 11:58:56 -0000
@@ -326,6 +326,10 @@ case "${target}" in
 			srv_xmlfiles="$srv_i386_xmlfiles $srv_amd64_xmlfiles"
 			srv_mingw=yes
 			;;
+  x86_64-*-cygwin*)	srv_regobj="$srv_amd64_regobj"
+			srv_tgtobj="i386-low.o i387-fp.o win32-low.o win32-i386-low.o"
+			srv_xmlfiles="$srv_i386_xmlfiles"
+			;;
 
   xtensa*-*-linux*)	srv_regobj=reg-xtensa.o
 			srv_tgtobj="linux-low.o linux-osdata.o linux-xtensa-low.o linux-procfs.o"

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Re: New target: x86_64-pc-cygwin

[Pedro Alves]

On 03/05/2013 12:00 PM, Corinna Vinschen wrote:

> 	* configure.host: Add x86_64-*-cygwin* as host.
> 	* configure.tgt: Add x86_64-*-cygwin* as target.
> 	* config/i386/cygwin64.mh: New file.

OK with the issue below addressed.

> 	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.

OK, but this goes to gdbserver/ChangeLog.

> RCS file: config/i386/cygwin64.mh
> diff -N config/i386/cygwin64.mh
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ config/i386/cygwin64.mh	5 Mar 2013 11:58:56 -0000
> @@ -0,0 +1 @@
> +NATDEPFILES= i386-nat.o windows-nat.o amd64-windows-nat.o

We're now making an effort to add copyright headers to all
config/ files (even small one liners).  You can copy the header
from config/powerpc/fbsd.mh.

-- 
Pedro Alves

Re: New target: x86_64-pc-cygwin

[Pedro Alves]

BTW, I forgot...

New targets get a NEWS entry.

-- 
Pedro Alves

Re: New target: x86_64-pc-cygwin

[Joel Brobecker]

Hi Corinna,

> 	* configure.host: Add x86_64-*-cygwin* as host.
> 	* configure.tgt: Add x86_64-*-cygwin* as target.
> 	* config/i386/cygwin64.mh: New file.

This part looks good to me, so please go ahead and commit.

> 	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.

[gdbserver has its own ChangeLog]

This parts looks good to me, but should probably be reviewed by Pedro
as well.

> Index: gdbserver/configure.srv
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
> retrieving revision 1.72
> diff -u -p -r1.72 configure.srv
> --- gdbserver/configure.srv	27 Feb 2013 14:58:18 -0000	1.72
> +++ gdbserver/configure.srv	5 Mar 2013 11:58:56 -0000
> @@ -326,6 +326,10 @@ case "${target}" in
>  			srv_xmlfiles="$srv_i386_xmlfiles $srv_amd64_xmlfiles"
>  			srv_mingw=yes
>  			;;
> +  x86_64-*-cygwin*)	srv_regobj="$srv_amd64_regobj"
> +			srv_tgtobj="i386-low.o i387-fp.o win32-low.o win32-i386-low.o"
> +			srv_xmlfiles="$srv_i386_xmlfiles"
> +			;;
>  
>    xtensa*-*-linux*)	srv_regobj=reg-xtensa.o
>  			srv_tgtobj="linux-low.o linux-osdata.o linux-xtensa-low.o linux-procfs.o"

-- 
Joel

Re: New target: x86_64-pc-cygwin

[Corinna Vinschen]

On Mar  5 13:29, Pedro Alves wrote:
> BTW, I forgot...
> 
> New targets get a NEWS entry.

Patch applied with the requested changes.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Re: New target: x86_64-pc-cygwin

[Pedro Alves]

On 03/05/2013 01:39 PM, Corinna Vinschen wrote:
> On Mar  5 13:29, Pedro Alves wrote:
>> BTW, I forgot...
>>
>> New targets get a NEWS entry.
> 
> Patch applied with the requested changes.

Thanks.

Sorry for the pedantry, I'll note gdb's policy is if
there were changes, to post the patch that goes into cvs.

NEWS changes are usually reviewed by Eli, but
I agree the change was an obvious one.

--- src/gdb/gdbserver/ChangeLog	2013/02/28 16:51:19	1.688
+++ src/gdb/gdbserver/ChangeLog	2013/03/05 13:37:11	1.689
@@ -1,3 +1,7 @@
+2013-03-05  Corinna Vinschen  <vinschen@redhat.de>
+
+	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.

This "gdbserver/" bit should be removed though.

-- 
Pedro Alves

Re: New target: x86_64-pc-cygwin

[Corinna Vinschen]

On Mar  5 15:02, Pedro Alves wrote:
> On 03/05/2013 01:39 PM, Corinna Vinschen wrote:
> > On Mar  5 13:29, Pedro Alves wrote:
> >> BTW, I forgot...
> >>
> >> New targets get a NEWS entry.
> > 
> > Patch applied with the requested changes.
> 
> Thanks.
> 
> Sorry for the pedantry, I'll note gdb's policy is if
> there were changes, to post the patch that goes into cvs.
> 
> NEWS changes are usually reviewed by Eli, but
> I agree the change was an obvious one.
> 
> --- src/gdb/gdbserver/ChangeLog	2013/02/28 16:51:19	1.688
> +++ src/gdb/gdbserver/ChangeLog	2013/03/05 13:37:11	1.689
> @@ -1,3 +1,7 @@
> +2013-03-05  Corinna Vinschen  <vinschen@redhat.de>
> +
> +	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.
> 
> This "gdbserver/" bit should be removed though.

Sorry about that on both accounts.  I fixed the gdbserver ChangeLog entry.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Re: New target: x86_64-pc-cygwin

[Pedro Alves]

On 03/05/2013 03:18 PM, Corinna Vinschen wrote:
> On Mar  5 15:02, Pedro Alves wrote:
>> On 03/05/2013 01:39 PM, Corinna Vinschen wrote:
>>> On Mar  5 13:29, Pedro Alves wrote:
>>>> BTW, I forgot...
>>>>
>>>> New targets get a NEWS entry.
>>>
>>> Patch applied with the requested changes.
>>
>> Thanks.
>>
>> Sorry for the pedantry, I'll note gdb's policy is if
>> there were changes, to post the patch that goes into cvs.
>>
>> NEWS changes are usually reviewed by Eli, but
>> I agree the change was an obvious one.
>>
>> --- src/gdb/gdbserver/ChangeLog	2013/02/28 16:51:19	1.688
>> +++ src/gdb/gdbserver/ChangeLog	2013/03/05 13:37:11	1.689
>> @@ -1,3 +1,7 @@
>> +2013-03-05  Corinna Vinschen  <vinschen@redhat.de>
>> +
>> +	* gdbserver/configure.srv: Add x86_64-*-cygwin* as target.
>>
>> This "gdbserver/" bit should be removed though.
> 
> Sorry about that on both accounts.  I fixed the gdbserver ChangeLog entry.

Not a problem at all.

Thanks,
-- 
Pedro Alves