From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash in read_pe_exported_syms
Date: Mon, 04 Mar 2013 14:35:00 -0000 [thread overview]
Message-ID: <20130304143449.GH2481@calimero.vinschen.de> (raw)
In-Reply-To: <51349AE4.3070200@redhat.com>
On Mar 4 13:00, Pedro Alves wrote:
> On 03/02/2013 11:02 AM, Corinna Vinschen wrote:
>
> (...)
>
> I'm not myself against gotos, but indeed GDB's style leans
> largely on the "call do_cleanups before return" for early
> returns.
Well, grepping for "goto" in the code returns >500 places. I checked
that before sending my patch...
> On that basis,
>
> > Below is a patch. Ok to apply?
>
> OK with Sergio's suggestion.
I really think that lots of
do_cleanup();
return;
blocks are more error prone and less readable than a goto to a defined
label at the end of a function. Are you really sure you want that?
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
next prev parent reply other threads:[~2013-03-04 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 11:02 Corinna Vinschen
2013-03-02 15:31 ` Pierre Muller
2013-03-03 23:06 ` Sergio Durigan Junior
2013-03-03 22:53 ` Sergio Durigan Junior
2013-03-04 13:24 ` Pedro Alves
2013-03-04 14:35 ` Corinna Vinschen [this message]
2013-03-04 14:41 ` Joel Brobecker
2013-03-04 15:10 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304143449.GH2481@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox