From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25162 invoked by alias); 4 Mar 2013 14:35:27 -0000 Received: (qmail 22944 invoked by uid 22791); 4 Mar 2013 14:34:59 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 04 Mar 2013 14:34:52 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id EA318520242; Mon, 4 Mar 2013 15:34:49 +0100 (CET) Date: Mon, 04 Mar 2013 14:35:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash in read_pe_exported_syms Message-ID: <20130304143449.GH2481@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20130302110216.GA6765@calimero.vinschen.de> <51349AE4.3070200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51349AE4.3070200@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00085.txt.bz2 On Mar 4 13:00, Pedro Alves wrote: > On 03/02/2013 11:02 AM, Corinna Vinschen wrote: > > (...) > > I'm not myself against gotos, but indeed GDB's style leans > largely on the "call do_cleanups before return" for early > returns. Well, grepping for "goto" in the code returns >500 places. I checked that before sending my patch... > On that basis, > > > Below is a patch. Ok to apply? > > OK with Sergio's suggestion. I really think that lots of do_cleanup(); return; blocks are more error prone and less readable than a goto to a defined label at the end of a function. Are you really sure you want that? Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat