From: David Miller <davem@davemloft.net>
To: uweigand@de.ibm.com
Cc: gdb-patches@sourceware.org, kettenis@gnu.org
Subject: Re: [PATCH] Allow struct 'return' on 32-bit sparc.
Date: Fri, 08 Feb 2013 19:13:00 -0000 [thread overview]
Message-ID: <20130208.141300.538917519438866034.davem@davemloft.net> (raw)
In-Reply-To: <20130208.141007.1843341118019750539.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 08 Feb 2013 14:10:07 -0500 (EST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> Date: Fri, 8 Feb 2013 19:16:39 +0100 (CET)
>
>> David Miller wrote:
>>
>>> @@ -2327,6 +2328,7 @@ return_command (char *retval_exp, int from_tty)
>>> if (thisfun != NULL)
>>> function = read_var_value (thisfun, thisframe);
>>>
>>> + rv_conv = RETURN_VALUE_REGISTER_CONVENTION;
>>> if (TYPE_CODE (return_type) == TYPE_CODE_VOID)
>>> /* If the return-type is "void", don't try to find the
>>> return-value's location. However, do still evaluate the
>>
>> Maybe just move this up to the definition?
>
> Yes, that's a good idea, I'll commit such a fix.
Actually someone beat me to it :-)
2013-02-08 Matthew Gretton-Dann <matthew.gretton-dann@linaro.org>
* stack.c (return_command): Work around uninitialized variable
warning.
prev parent reply other threads:[~2013-02-08 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 21:13 David Miller
2013-02-04 23:57 ` Mark Kettenis
2013-02-05 1:03 ` David Miller
2013-02-05 20:19 ` Mark Kettenis
2013-02-05 20:31 ` David Miller
2013-02-06 19:41 ` David Miller
2013-02-08 18:17 ` Ulrich Weigand
2013-02-08 19:10 ` David Miller
2013-02-08 19:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208.141300.538917519438866034.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox