From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28005 invoked by alias); 8 Feb 2013 19:13:12 -0000 Received: (qmail 27969 invoked by uid 22791); 8 Feb 2013 19:13:10 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (149.20.54.216) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Feb 2013 19:13:02 +0000 Received: from localhost (cpe-66-108-118-205.nyc.res.rr.com [66.108.118.205]) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 898A2583C2C; Fri, 8 Feb 2013 11:13:05 -0800 (PST) Date: Fri, 08 Feb 2013 19:13:00 -0000 Message-Id: <20130208.141300.538917519438866034.davem@davemloft.net> To: uweigand@de.ibm.com Cc: gdb-patches@sourceware.org, kettenis@gnu.org Subject: Re: [PATCH] Allow struct 'return' on 32-bit sparc. From: David Miller In-Reply-To: <20130208.141007.1843341118019750539.davem@davemloft.net> References: <20130201.161300.1158114789368969492.davem@davemloft.net> <201302081816.r18IGd4s006087@d06av02.portsmouth.uk.ibm.com> <20130208.141007.1843341118019750539.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00227.txt.bz2 From: David Miller Date: Fri, 08 Feb 2013 14:10:07 -0500 (EST) > From: "Ulrich Weigand" > Date: Fri, 8 Feb 2013 19:16:39 +0100 (CET) > >> David Miller wrote: >> >>> @@ -2327,6 +2328,7 @@ return_command (char *retval_exp, int from_tty) >>> if (thisfun != NULL) >>> function = read_var_value (thisfun, thisframe); >>> >>> + rv_conv = RETURN_VALUE_REGISTER_CONVENTION; >>> if (TYPE_CODE (return_type) == TYPE_CODE_VOID) >>> /* If the return-type is "void", don't try to find the >>> return-value's location. However, do still evaluate the >> >> Maybe just move this up to the definition? > > Yes, that's a good idea, I'll commit such a fix. Actually someone beat me to it :-) 2013-02-08 Matthew Gretton-Dann * stack.c (return_command): Work around uninitialized variable warning.