From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: record-btrace
Date: Wed, 06 Feb 2013 14:58:00 -0000 [thread overview]
Message-ID: <20130206145832.GA5219@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307B6A503@IRSMSX102.ger.corp.intel.com>
On Wed, 06 Feb 2013 13:25:07 +0100, Metzger, Markus T wrote:
> For "target record", I added a full command using add_cmd. When I use add_alias_cmd
> and then deprecate_cmd on the returned command, I do not get the warning.
OK, I see there now your:
/* If we use add_alias_cmd, here, we do not get the deprecated warning. */
I have added PR cli/15104 for that, it could be mentioned in the comment,
otherwise I am OK with it this way.
> > > + Copyright (C) 2008-2013 Free Software Foundation, Inc.
> >
> > This is a new file, 2013 is enough.
>
> It has been copied from record.h so I kept the copyright.
I do not understand the rules but AFAIK new files do not / should not keep
copyright years for their possible moved in content.
> You can help me hook up a stack unwinder in exchange;-)
The stack unwinder which refuses unwind when we are in btrace history, OK.
Thanks,
Jan
prev parent reply other threads:[~2013-02-06 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 16:14 record-btrace Metzger, Markus T
2013-01-29 9:53 ` record-btrace Jan Kratochvil
2013-01-29 11:05 ` record-btrace Metzger, Markus T
2013-01-29 15:36 ` record-btrace Jan Kratochvil
2013-01-31 15:38 ` record-btrace Metzger, Markus T
2013-02-01 14:18 ` record-btrace Jan Kratochvil
2013-02-04 14:31 ` record-btrace Metzger, Markus T
2013-02-05 19:45 ` record-btrace Jan Kratochvil
2013-02-06 12:25 ` record-btrace Metzger, Markus T
2013-02-06 14:58 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206145832.GA5219@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox