From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30593 invoked by alias); 6 Feb 2013 14:58:45 -0000 Received: (qmail 30582 invoked by uid 22791); 6 Feb 2013 14:58:44 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 14:58:39 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r16EwaaT026198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Feb 2013 09:58:36 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r16EwW0o021822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 6 Feb 2013 09:58:35 -0500 Date: Wed, 06 Feb 2013 14:58:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: "markus.t.metzger@gmail.com" , "gdb-patches@sourceware.org" Subject: Re: record-btrace Message-ID: <20130206145832.GA5219@host2.jankratochvil.net> References: <20130129095303.GA12614@host2.jankratochvil.net> <20130129153617.GA28655@host2.jankratochvil.net> <20130201141829.GA24703@host2.jankratochvil.net> <20130205194508.GA9091@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00142.txt.bz2 On Wed, 06 Feb 2013 13:25:07 +0100, Metzger, Markus T wrote: > For "target record", I added a full command using add_cmd. When I use add_alias_cmd > and then deprecate_cmd on the returned command, I do not get the warning. OK, I see there now your: /* If we use add_alias_cmd, here, we do not get the deprecated warning. */ I have added PR cli/15104 for that, it could be mentioned in the comment, otherwise I am OK with it this way. > > > + Copyright (C) 2008-2013 Free Software Foundation, Inc. > > > > This is a new file, 2013 is enough. > > It has been copied from record.h so I kept the copyright. I do not understand the rules but AFAIK new files do not / should not keep copyright years for their possible moved in content. > You can help me hook up a stack unwinder in exchange;-) The stack unwinder which refuses unwind when we are in btrace history, OK. Thanks, Jan