From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: remove unused - solib
Date: Thu, 31 Jan 2013 06:23:00 -0000 [thread overview]
Message-ID: <20130131062307.GA2826@host2.jankratochvil.net> (raw)
In-Reply-To: <5109E36E.9000209@qnx.com>
On Thu, 31 Jan 2013 04:22:22 +0100, Aleksandar Ristovski wrote:
> Aleksandar Ristovski <aristovski@qnx.com>
>
> * solib-svr4.c (svr4_keep_data_in_core): Remove unused LMO.
> (svr4_read_so_list): Remove unused LMO.
> * solib-target.c (solib_target_relocate_section_addresses):
> Remove unused
> FLAGS.
This is OK, I expected you consider them pre-approved.
As a nitpick here the variables should be lowercased, as we talk about the
variables and not their values:
http://www.gnu.org/prep/standards/standards.html
The comment on a function is much clearer if you use the argument
names to speak about the argument values. The variable name itself
should be lower case, but write it in upper case when you are speaking
about the value rather than the variable itself. Thus, “the inode
number NODE_NUM” rather than “an inode”.
Thanks,
Jan
next prev parent reply other threads:[~2013-01-31 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 3:22 Aleksandar Ristovski
2013-01-31 6:23 ` Jan Kratochvil [this message]
2013-01-31 13:55 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131062307.GA2826@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox