From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20173 invoked by alias); 31 Jan 2013 06:23:25 -0000 Received: (qmail 20052 invoked by uid 22791); 31 Jan 2013 06:23:22 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Jan 2013 06:23:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0V6NC3l013339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 31 Jan 2013 01:23:12 -0500 Received: from host2.jankratochvil.net (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0V6N84h016071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 31 Jan 2013 01:23:11 -0500 Date: Thu, 31 Jan 2013 06:23:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] cleanup: remove unused - solib Message-ID: <20130131062307.GA2826@host2.jankratochvil.net> References: <5109E36E.9000209@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <5109E36E.9000209@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00744.txt.bz2 On Thu, 31 Jan 2013 04:22:22 +0100, Aleksandar Ristovski wrote: > Aleksandar Ristovski > > * solib-svr4.c (svr4_keep_data_in_core): Remove unused LMO. > (svr4_read_so_list): Remove unused LMO. > * solib-target.c (solib_target_relocate_section_addresses): > Remove unused > FLAGS. This is OK, I expected you consider them pre-approved. As a nitpick here the variables should be lowercased, as we talk about the variables and not their values: http://www.gnu.org/prep/standards/standards.html The comment on a function is much clearer if you use the argument names to speak about the argument values. The variable name itself should be lower case, but write it in upper case when you are speaking about the value rather than the variable itself. Thus, “the inode number NODE_NUM” rather than “an inode”. Thanks, Jan