Re: [patch 7/9] Fix psymtab.c for real and absolute filenames

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 23 Jan 2013 22:31:30 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> partial symtabs did not handle correctly absolute filenames and they had
> Jan> problems also with expansion on symlinks.
> 
       -	  if (! (*file_matcher) (ps->filename, data))
> Jan> +	  if (!(*file_matcher) (psymtab_to_fullname (ps), data)
> Jan> +	      && !(*file_matcher) (psymtab_to_realname (ps), data))
> Jan>  	    continue;
> 
> Doesn't this tend to eliminate the benefit of using xfullpath?

Primarily xfullpath is gone (in the next patch series) so this change will be
undone there.

This meant:

if ((*file_matcher) (psymtab_to_fullname (ps), data)
    || (*file_matcher) (psymtab_to_realname (ps), data))
  do-it.

Which seems correct to me.  I do not understand much your comment.

But I see there another bug, that it no longer tests ps->filename, so that it
would not match that "./gdb.base/return.c:main" because fullpath no longer has
that "./" there.


Thanks,
Jan