From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22945 invoked by alias); 25 Jan 2013 14:48:49 -0000 Received: (qmail 22936 invoked by uid 22791); 25 Jan 2013 14:48:47 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jan 2013 14:48:12 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0PEmB0w024740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Jan 2013 09:48:11 -0500 Received: from host2.jankratochvil.net (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0PEm7eN021959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 25 Jan 2013 09:48:10 -0500 Date: Fri, 25 Jan 2013 14:48:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 7/9] Fix psymtab.c for real and absolute filenames Message-ID: <20130125144807.GA16342@host2.jankratochvil.net> References: <20130117222339.GH16249@host2.jankratochvil.net> <87ip6ntwlp.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ip6ntwlp.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00627.txt.bz2 On Wed, 23 Jan 2013 22:31:30 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> partial symtabs did not handle correctly absolute filenames and they had > Jan> problems also with expansion on symlinks. > - if (! (*file_matcher) (ps->filename, data)) > Jan> + if (!(*file_matcher) (psymtab_to_fullname (ps), data) > Jan> + && !(*file_matcher) (psymtab_to_realname (ps), data)) > Jan> continue; > > Doesn't this tend to eliminate the benefit of using xfullpath? Primarily xfullpath is gone (in the next patch series) so this change will be undone there. This meant: if ((*file_matcher) (psymtab_to_fullname (ps), data) || (*file_matcher) (psymtab_to_realname (ps), data)) do-it. Which seems correct to me. I do not understand much your comment. But I see there another bug, that it no longer tests ps->filename, so that it would not match that "./gdb.base/return.c:main" because fullpath no longer has that "./" there. Thanks, Jan