From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
Date: Fri, 25 Jan 2013 14:30:00 -0000 [thread overview]
Message-ID: <20130125142951.GA15143@host2.jankratochvil.net> (raw)
In-Reply-To: <87fw1pl4lb.fsf@fleche.redhat.com>
On Fri, 25 Jan 2013 15:28:16 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Tom> This spot still uses symtab->filename directly.
> Tom> Is that intentional? If so I think it should perhaps have a comment.
>
> Jan> Yes.
> Jan> + /* Check first sole SYMTAB->FILENAME. It does not need to be
> Jan> + a substring of symtab_to_fullname as it may contain "./" etc. */
>
> Sorry, missed that.
It was a missing comment from me, I just agreed by "Yes." there should be
a comment and so I created a new comment on the local branch to be posted
later.
Thanks for the suggestion.
Jan
prev parent reply other threads:[~2013-01-25 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 22:23 Jan Kratochvil
2013-01-21 19:34 ` Tom Tromey
2013-01-24 21:56 ` Jan Kratochvil
2013-01-25 14:28 ` Tom Tromey
2013-01-25 14:30 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125142951.GA15143@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox