From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30444 invoked by alias); 25 Jan 2013 14:30:56 -0000 Received: (qmail 30427 invoked by uid 22791); 25 Jan 2013 14:30:54 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jan 2013 14:29:56 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0PETtjJ026103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Jan 2013 09:29:56 -0500 Received: from host2.jankratochvil.net (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0PETphX009300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 25 Jan 2013 09:29:54 -0500 Date: Fri, 25 Jan 2013 14:30:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename Message-ID: <20130125142951.GA15143@host2.jankratochvil.net> References: <20130117222242.GG16249@host2.jankratochvil.net> <87ip6q1gbo.fsf@fleche.redhat.com> <20130124215609.GA31688@host2.jankratochvil.net> <87fw1pl4lb.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fw1pl4lb.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00626.txt.bz2 On Fri, 25 Jan 2013 15:28:16 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Tom> This spot still uses symtab->filename directly. > Tom> Is that intentional? If so I think it should perhaps have a comment. > > Jan> Yes. > Jan> + /* Check first sole SYMTAB->FILENAME. It does not need to be > Jan> + a substring of symtab_to_fullname as it may contain "./" etc. */ > > Sorry, missed that. It was a missing comment from me, I just agreed by "Yes." there should be a comment and so I created a new comment on the local branch to be posted later. Thanks for the suggestion. Jan