Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR c++/14999
Date: Tue, 22 Jan 2013 02:55:00 -0000	[thread overview]
Message-ID: <20130122025511.GB5215@adacore.com> (raw)
In-Reply-To: <878v7m4j55.fsf@fleche.redhat.com>

> Can you try the appended instead?
> I am testing it here as well.

Thanks, Tom. I confirm your patch seems to be fixing the issue as well.

> diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
> index 2282feb..3688425 100644
> --- a/gdb/dwarf2loc.c
> +++ b/gdb/dwarf2loc.c
> @@ -2878,7 +2878,8 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc,
>  	    op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset);
>  	    dwarf2_compile_expr_to_ax (expr, loc, arch, addr_size, datastart,
>  				       datastart + datalen, per_cu);
> -	    require_rvalue (expr, loc);
> +	    if (loc->kind == axs_lvalue_register)
> +	      require_rvalue (expr, loc);
>  
>  	    if (offset != 0)
>  	      {

-- 
Joel


  reply	other threads:[~2013-01-22  2:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 17:11 Tom Tromey
2013-01-18 18:25 ` Tom Tromey
2013-01-19 15:54 ` Joel Brobecker
2013-01-19 19:34   ` Tom Tromey
2013-01-21 16:04   ` Tom Tromey
2013-01-22  2:55     ` Joel Brobecker [this message]
2013-01-22 15:57       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130122025511.GB5215@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox