From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13903 invoked by alias); 22 Jan 2013 02:55:25 -0000 Received: (qmail 13895 invoked by uid 22791); 22 Jan 2013 02:55:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 02:55:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D4A842E1EC; Mon, 21 Jan 2013 21:55:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TIgjpHLWZl31; Mon, 21 Jan 2013 21:55:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 69BFE2E1E9; Mon, 21 Jan 2013 21:55:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A35E4C3962; Tue, 22 Jan 2013 06:55:11 +0400 (RET) Date: Tue, 22 Jan 2013 02:55:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix PR c++/14999 Message-ID: <20130122025511.GB5215@adacore.com> References: <87mwwj38hm.fsf@fleche.redhat.com> <20130119155435.GA5215@adacore.com> <878v7m4j55.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878v7m4j55.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00503.txt.bz2 > Can you try the appended instead? > I am testing it here as well. Thanks, Tom. I confirm your patch seems to be fixing the issue as well. > diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c > index 2282feb..3688425 100644 > --- a/gdb/dwarf2loc.c > +++ b/gdb/dwarf2loc.c > @@ -2878,7 +2878,8 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, > op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset); > dwarf2_compile_expr_to_ax (expr, loc, arch, addr_size, datastart, > datastart + datalen, per_cu); > - require_rvalue (expr, loc); > + if (loc->kind == axs_lvalue_register) > + require_rvalue (expr, loc); > > if (offset != 0) > { -- Joel