From: Joel Brobecker <brobecker@adacore.com>
To: Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"binutils@sourceware.org" <binutils@sourceware.org>,
Pedro Alves <palves@redhat.com>, Yao Qi <yao@codesourcery.com>,
nick clifton <nickc@redhat.com>, Tom Tromey <tromey@redhat.com>
Subject: Re: [RFA 3/5] New port: CR16: gdb port
Date: Fri, 18 Jan 2013 14:17:00 -0000 [thread overview]
Message-ID: <20130118141649.GK3564@adacore.com> (raw)
In-Reply-To: <C6CA53A2A46BA7469348BDBD663AB65848569146@KCHJEXMB02.kpit.com>
> Thanks for spending time on this. I have tried to address all your
> points in this updated patch.
And I confirm you did :).
> 2013-01-18 Kaushik Phatak <kaushik.phatak@kpitcummins.com>
> gdb/Changelog
> * configure.tgt: Handle cr16*-*-*linux and cr16*-*-*.
> * cr16-linux-tdep.c: New file.
> * cr16-tdep.c: New file.
> * cr16-tdep.h: New file.
Looks good to me.
One warning, though: You added src/configure.ac and src/configure
to the patch. JIC we hadn't mentioned this, this part is controlled
by GCC, and needs to be approved there. You can go ahead and commit
the GDB part.
--
Joel
next prev parent reply other threads:[~2013-01-18 14:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 10:22 Kaushik Phatak
2012-10-04 14:48 ` Joel Brobecker
2012-10-05 11:44 ` Kaushik Phatak
2012-10-05 12:21 ` Joel Brobecker
2012-10-09 13:20 ` Kaushik Phatak
2012-10-08 6:59 ` Yao Qi
2012-10-09 15:03 ` Kaushik Phatak
2012-10-22 22:41 ` Joel Brobecker
2012-10-23 13:03 ` Kaushik Phatak
2012-10-23 13:55 ` Joel Brobecker
2012-10-26 5:15 ` Kaushik Phatak
2012-11-15 17:43 ` Joel Brobecker
2012-11-20 13:01 ` Kaushik Phatak
2012-11-22 17:50 ` Joel Brobecker
2013-01-08 10:02 ` Kaushik Phatak
2013-01-15 9:31 ` Kaushik Phatak
2013-01-17 8:59 ` Joel Brobecker
2013-01-18 7:41 ` Kaushik Phatak
2013-01-18 14:17 ` Joel Brobecker [this message]
2013-01-22 13:49 ` Kaushik Phatak
2013-01-22 15:43 ` Pedro Alves
2013-01-23 14:22 ` Kaushik Phatak
2013-01-23 14:26 ` Pedro Alves
2013-01-23 15:34 ` Pedro Alves
2013-06-19 13:30 ` Kaushik Phatak
2013-06-25 18:42 ` Pedro Alves
2013-06-26 7:08 ` Kaushik Phatak
2013-06-26 10:37 ` Pedro Alves
2013-01-18 18:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118141649.GK3564@adacore.com \
--to=brobecker@adacore.com \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox