From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6177 invoked by alias); 18 Jan 2013 14:17:07 -0000 Received: (qmail 6157 invoked by uid 22791); 18 Jan 2013 14:17:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 14:17:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BD13A2E685; Fri, 18 Jan 2013 09:17:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vwaJo3bIHCf8; Fri, 18 Jan 2013 09:17:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2D8252E67E; Fri, 18 Jan 2013 09:16:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2AD56C3EEF; Fri, 18 Jan 2013 18:16:49 +0400 (RET) Date: Fri, 18 Jan 2013 14:17:00 -0000 From: Joel Brobecker To: Kaushik Phatak Cc: "gdb-patches@sourceware.org" , "binutils@sourceware.org" , Pedro Alves , Yao Qi , nick clifton , Tom Tromey Subject: Re: [RFA 3/5] New port: CR16: gdb port Message-ID: <20130118141649.GK3564@adacore.com> References: <20121022224107.GB3713@adacore.com> <20121023135502.GA3555@adacore.com> <20121115174313.GC3790@adacore.com> <20121122175010.GG9964@adacore.com> <20130117085919.GA3564@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00422.txt.bz2 > Thanks for spending time on this. I have tried to address all your > points in this updated patch. And I confirm you did :). > 2013-01-18 Kaushik Phatak > gdb/Changelog > * configure.tgt: Handle cr16*-*-*linux and cr16*-*-*. > * cr16-linux-tdep.c: New file. > * cr16-tdep.c: New file. > * cr16-tdep.h: New file. Looks good to me. One warning, though: You added src/configure.ac and src/configure to the patch. JIC we hadn't mentioned this, this part is controlled by GCC, and needs to be approved there. You can go ahead and commit the GDB part. -- Joel