From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Eli Zaretskii' <eliz@gnu.org>,
'Andreas Schwab' <schwab@linux-m68k.org>,
gdb-patches@sourceware.org
Subject: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement
Date: Fri, 11 Jan 2013 04:29:00 -0000 [thread overview]
Message-ID: <20130111042931.GJ6143@adacore.com> (raw)
In-Reply-To: <000901cdef2d$dd0f32e0$972d98a0$@muller@ics-cnrs.unistra.fr>
> I would like to know what the status of this patch is,
> and more generally of the ARI rule: "Avoid assignment inside if statement".
I think that we should continue to discourage the use of assignments
inside if statements, and the ARI is a good tool for that. If someone
happens to come across a situation where it is clearly advantageous
to break this rule, then we can document it using an ARI comment
that clearly allows it.
--
Joel
next prev parent reply other threads:[~2013-01-11 4:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr>
2012-12-23 19:29 ` Eli Zaretskii
2012-12-23 21:58 ` Pierre Muller
2012-12-23 22:28 ` Sergio Durigan Junior
2012-12-24 4:11 ` Joel Brobecker
2012-12-23 22:28 ` Andreas Schwab
2012-12-24 3:41 ` Eli Zaretskii
2012-12-24 10:17 ` Andreas Schwab
2013-01-10 12:28 ` Pierre Muller
2013-01-11 4:29 ` Joel Brobecker [this message]
2012-12-23 19:00 Pierre Muller
2012-12-24 4:17 ` Joel Brobecker
2012-12-24 10:22 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111042931.GJ6143@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox