From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13906 invoked by alias); 11 Jan 2013 04:29:44 -0000 Received: (qmail 13873 invoked by uid 22791); 11 Jan 2013 04:29:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jan 2013 04:29:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DD2B42E305; Thu, 10 Jan 2013 23:29:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6JsJRyA-nYp5; Thu, 10 Jan 2013 23:29:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BEEB22E172; Thu, 10 Jan 2013 23:29:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CC69CC3755; Fri, 11 Jan 2013 08:29:31 +0400 (RET) Date: Fri, 11 Jan 2013 04:29:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Eli Zaretskii' , 'Andreas Schwab' , gdb-patches@sourceware.org Subject: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement Message-ID: <20130111042931.GJ6143@adacore.com> References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr> <837go8pnxn.fsf@gnu.org> <834njcp160.fsf@gnu.org> <000901cdef2d$dd0f32e0$972d98a0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000901cdef2d$dd0f32e0$972d98a0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00210.txt.bz2 > I would like to know what the status of this patch is, > and more generally of the ARI rule: "Avoid assignment inside if statement". I think that we should continue to discourage the use of assignments inside if statements, and the ARI is a good tool for that. If someone happens to come across a situation where it is clearly advantageous to break this rule, then we can document it using an ARI comment that clearly allows it. -- Joel