Re: [PATCH] TASK_DYLD_INFO_COUNT build fix for darwin9

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

> i've committed this slightly tweaked version

Unfortunately, it looks like you accidently changed an "#ifdef"
into a "#ifndef".  The build is failing for me. Fixed thusly.

gdb/ChangeLog:

        * darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test
        used to decide whether to define darwin_read_dyld_info or not.

You'll might want to ask your collegue/friend to rebuild to make sure
it works. I suspect it wouldn't have worked before my patch for him
either.

Cheers,
-- 
Joel

[-- Attachment #2: 0001-Fix-build-failure-on-darwin-due-to-darwin_read_dyld_.patch --]
[-- Type: text/x-diff, Size: 1395 bytes --]

From 4682b679f3da36234b47a410b057f465434078d2 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 7 Jan 2013 06:00:29 -0500
Subject: [PATCH] Fix build failure on darwin due to darwin_read_dyld_info not
 being defined.

gdb/ChangeLog:

        * darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test
        used to decide whether to define darwin_read_dyld_info or not.
---
 gdb/ChangeLog    |    5 +++++
 gdb/darwin-nat.c |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ac806e9..69b71f5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-01-07  Joel Brobecker  <brobecker@adacore.com>
+
+	* darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test
+	used to decide whether to define darwin_read_dyld_info or not.
+
 2013-01-03  Pierre Muller  <muller@sourceware.org>
 
 	* main.c (relocate_gdb_directory): Avoid calling stat function
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 0307048..1344101 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -1818,7 +1818,7 @@ out:
    to RDADDR.
    Return 0 on failure; number of bytes read / written otherwise.  */
 
-#ifndef TASK_DYLD_INFO_COUNT
+#ifdef TASK_DYLD_INFO_COUNT
 /* This is not available in Darwin 9.  */
 static int
 darwin_read_dyld_info (task_t task, CORE_ADDR addr, char *rdaddr, int length)
-- 
1.7.10.4