From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5062 invoked by alias); 7 Jan 2013 11:21:02 -0000 Received: (qmail 5046 invoked by uid 22791); 7 Jan 2013 11:21:00 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jan 2013 11:20:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 91B182E425; Mon, 7 Jan 2013 06:20:54 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VqdB4+N0Xvd2; Mon, 7 Jan 2013 06:20:54 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 105C12E227; Mon, 7 Jan 2013 06:20:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 14862C2569; Mon, 7 Jan 2013 15:20:47 +0400 (RET) Date: Mon, 07 Jan 2013 11:21:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, Tristan Gingold , Fabian Groffen Subject: Re: [PATCH] TASK_DYLD_INFO_COUNT build fix for darwin9 Message-ID: <20130107112046.GA23906@adacore.com> References: <20130102183848.GM14383@gentoo.org> <937AAF12-6E3D-4F3D-8C1F-40A4D135CA54@adacore.com> <201301021607.24055.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <201301021607.24055.vapier@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00089.txt.bz2 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 495 > i've committed this slightly tweaked version Unfortunately, it looks like you accidently changed an "#ifdef" into a "#ifndef". The build is failing for me. Fixed thusly. gdb/ChangeLog: * darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test used to decide whether to define darwin_read_dyld_info or not. You'll might want to ask your collegue/friend to rebuild to make sure it works. I suspect it wouldn't have worked before my patch for him either. Cheers, -- Joel --17pEHd4RhPHOinZp Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-build-failure-on-darwin-due-to-darwin_read_dyld_.patch" Content-length: 1396 >From 4682b679f3da36234b47a410b057f465434078d2 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 7 Jan 2013 06:00:29 -0500 Subject: [PATCH] Fix build failure on darwin due to darwin_read_dyld_info not being defined. gdb/ChangeLog: * darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test used to decide whether to define darwin_read_dyld_info or not. --- gdb/ChangeLog | 5 +++++ gdb/darwin-nat.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ac806e9..69b71f5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-01-07 Joel Brobecker + + * darwin-nat.c: Fix typo in TASK_DYLD_INFO_COUNT macro test + used to decide whether to define darwin_read_dyld_info or not. + 2013-01-03 Pierre Muller * main.c (relocate_gdb_directory): Avoid calling stat function diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c index 0307048..1344101 100644 --- a/gdb/darwin-nat.c +++ b/gdb/darwin-nat.c @@ -1818,7 +1818,7 @@ out: to RDADDR. Return 0 on failure; number of bytes read / written otherwise. */ -#ifndef TASK_DYLD_INFO_COUNT +#ifdef TASK_DYLD_INFO_COUNT /* This is not available in Darwin 9. */ static int darwin_read_dyld_info (task_t task, CORE_ADDR addr, char *rdaddr, int length) -- 1.7.10.4 --17pEHd4RhPHOinZp--