From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/obv] Remove trailing space in gdbarch.sh.
Date: Thu, 13 Dec 2012 05:47:00 -0000 [thread overview]
Message-ID: <20121213054613.GC3578@adacore.com> (raw)
In-Reply-To: <50C8A3CD.3000608@redhat.com>
> I don't see such a difference, but the patch is of course fine.
>
> git blame on the corresponding line on gdbarch.h points at:
>
> Author: Joel Brobecker <brobecker@gnat.com>
> Date: Wed Oct 26 21:23:54 2011 +0000
This is my evil twin :-).
> 2012-12-12 Pedro Alves <palves@redhat.com>
>
> * gdbarch.sh (do_read): Set IFS to blank.
Looks good to me.
Good analysis, as /bin/sh is indeed a link to dash on my laptop.
Thanks,
--
Joel
next prev parent reply other threads:[~2012-12-13 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 13:56 Joel Brobecker
2012-12-12 15:33 ` Pedro Alves
2012-12-12 15:46 ` Tom Tromey
2012-12-13 5:47 ` Joel Brobecker [this message]
2012-12-13 10:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213054613.GC3578@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox