From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21522 invoked by alias); 13 Dec 2012 05:47:06 -0000 Received: (qmail 21503 invoked by uid 22791); 13 Dec 2012 05:47:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 05:46:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 247BC1C79FB; Thu, 13 Dec 2012 00:46:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VxHff8JOkMH1; Thu, 13 Dec 2012 00:46:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B55A31C79F5; Thu, 13 Dec 2012 00:46:20 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E98F0C3734; Thu, 13 Dec 2012 09:46:13 +0400 (RET) Date: Thu, 13 Dec 2012 05:47:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [commit/obv] Remove trailing space in gdbarch.sh. Message-ID: <20121213054613.GC3578@adacore.com> References: <1355320564-6481-1-git-send-email-brobecker@adacore.com> <50C8A3CD.3000608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C8A3CD.3000608@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00430.txt.bz2 > I don't see such a difference, but the patch is of course fine. > > git blame on the corresponding line on gdbarch.h points at: > > Author: Joel Brobecker > Date: Wed Oct 26 21:23:54 2011 +0000 This is my evil twin :-). > 2012-12-12 Pedro Alves > > * gdbarch.sh (do_read): Set IFS to blank. Looks good to me. Good analysis, as /bin/sh is indeed a link to dash on my laptop. Thanks, -- Joel