Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tromey@redhat.com (Tom Tromey)
Cc: palves@redhat.com (Pedro Alves), dje@google.com (Doug Evans),
	       gdb-patches@sourceware.org
Subject: Re: RFA: handle "MiniDebuginfo" section
Date: Wed, 05 Dec 2012 17:09:00 -0000	[thread overview]
Message-ID: <201212051709.qB5H9R4p028267@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <8738zq24eg.fsf@fleche.redhat.com> from "Tom Tromey" at Nov 30, 2012 01:59:35 PM

Tom Tromey wrote:

> Ulrich> If I change the above filter to also accept "D", the test case
> Ulrich> goes further.  (It still ends up UNSUPPORTED, since it looks
> Ulrich> like I don't have LZMA on the system ...).  I'm not sure why the
> Ulrich> filter for "T" is done; would it change something critical to
> Ulrich> the test if "D" were added?
> 
> I think it would be fine.

OK, here's what I checked in.  Thanks again!

Bye,
Ulrich

ChangeLog:

	* gdb.base/gnu-debugdata.exp: Also include "D" symbols in
	${binfile}.funcsyms list.


Index: gdb/testsuite/gdb.base/gnu-debugdata.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gnu-debugdata.exp,v
retrieving revision 1.2
diff -u -p -r1.2 gnu-debugdata.exp
--- gdb/testsuite/gdb.base/gnu-debugdata.exp	29 Nov 2012 20:53:24 -0000	1.2
+++ gdb/testsuite/gdb.base/gnu-debugdata.exp	5 Dec 2012 17:05:02 -0000
@@ -95,10 +95,12 @@ if {[pipeline "nm -D" \
 }
 
 # Extract all the text (i.e. function) symbols from the debuginfo.
+# (Note that we actually also accept "D" symbols, for the benefit
+# of platforms like PowerPC64 that use function descriptors.)
 remote_file host delete ${binfile}.funcsyms
 if {[pipeline "nm" \
 	 [list [transform nm] "${binfile} --format=posix --defined-only"] \
-	 [list awk "\\{if(\\\$2==\"T\"||\\\$2==\"t\")print\\ \\\$1\\}"] \
+	 [list awk "\\{if(\\\$2==\"T\"||\\\$2==\"t\"||\\\$2==\"D\")print\\ \\\$1\\}"] \
 	 [list sort "" "" "${binfile}.funcsyms"]]} {
     return -1
 }


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2012-12-05 17:09 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 17:33 Tom Tromey
2012-11-09 18:07 ` Eli Zaretskii
2012-11-09 18:13 ` Pedro Alves
2012-11-09 21:28   ` Tom Tromey
2012-11-13 12:56     ` Pedro Alves
2012-11-13 15:26       ` Pedro Alves
2012-11-13 18:32       ` Tom Tromey
2012-11-09 18:23 ` Joel Brobecker
2012-11-09 18:53   ` Pedro Alves
2012-11-09 19:13   ` Tom Tromey
2012-11-12 16:04   ` Tom Tromey
2012-11-12 17:04     ` Joel Brobecker
2012-11-12 18:24       ` Tom Tromey
2012-11-12 16:28 ` Tom Tromey
2012-11-13 18:36   ` Tom Tromey
2012-11-13 18:42     ` Eli Zaretskii
2012-11-13 19:12     ` Pedro Alves
2012-11-13 20:57       ` Tom Tromey
2012-11-14 16:13         ` Tom Tromey
2012-11-14 16:19           ` Pedro Alves
2012-11-14 16:59             ` Tom Tromey
2012-11-14 19:37           ` Doug Evans
2012-11-14 22:12             ` Joel Brobecker
2012-11-15 11:18             ` Pedro Alves
2012-11-16 19:51               ` Tom Tromey
2012-11-19 14:41                 ` Pedro Alves
2012-11-26 19:21                   ` Tom Tromey
2012-11-26 22:24                     ` Andrew Pinski
2012-11-27  2:23                       ` Tom Tromey
2012-11-29 19:19                     ` Ulrich Weigand
2012-11-29 19:23                       ` Tom Tromey
2012-11-29 19:33                         ` Ulrich Weigand
2012-11-29 20:51                           ` Tom Tromey
2012-11-30 14:05                             ` Ulrich Weigand
2012-11-30 20:59                               ` Tom Tromey
2012-12-05 17:09                                 ` Ulrich Weigand [this message]
2012-12-11 16:42                     ` Yufeng Zhang
2012-11-16 20:04             ` Tom Tromey
2012-11-12 21:26 ` Doug Evans
2012-11-13 17:43   ` Tom Tromey
2012-11-13 15:44 ` Jan Kratochvil
2012-11-13 18:34   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201212051709.qB5H9R4p028267@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox