From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21581 invoked by alias); 5 Dec 2012 17:09:46 -0000 Received: (qmail 21571 invoked by uid 22791); 5 Dec 2012 17:09:43 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp18.uk.ibm.com (HELO e06smtp18.uk.ibm.com) (195.75.94.114) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 17:09:38 +0000 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Dec 2012 17:09:28 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp18.uk.ibm.com (192.168.101.148) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 5 Dec 2012 17:09:26 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qB5H9Pxa66060422 for ; Wed, 5 Dec 2012 17:09:25 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qB5H9VAq028564 for ; Wed, 5 Dec 2012 10:09:33 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id qB5H9R4p028267; Wed, 5 Dec 2012 10:09:28 -0700 Message-Id: <201212051709.qB5H9R4p028267@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 05 Dec 2012 18:09:27 +0100 Subject: Re: RFA: handle "MiniDebuginfo" section To: tromey@redhat.com (Tom Tromey) Date: Wed, 05 Dec 2012 17:09:00 -0000 From: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), dje@google.com (Doug Evans), gdb-patches@sourceware.org In-Reply-To: <8738zq24eg.fsf@fleche.redhat.com> from "Tom Tromey" at Nov 30, 2012 01:59:35 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12120517-6892-0000-0000-000003BD4FE9 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00076.txt.bz2 Tom Tromey wrote: > Ulrich> If I change the above filter to also accept "D", the test case > Ulrich> goes further. (It still ends up UNSUPPORTED, since it looks > Ulrich> like I don't have LZMA on the system ...). I'm not sure why the > Ulrich> filter for "T" is done; would it change something critical to > Ulrich> the test if "D" were added? > > I think it would be fine. OK, here's what I checked in. Thanks again! Bye, Ulrich ChangeLog: * gdb.base/gnu-debugdata.exp: Also include "D" symbols in ${binfile}.funcsyms list. Index: gdb/testsuite/gdb.base/gnu-debugdata.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gnu-debugdata.exp,v retrieving revision 1.2 diff -u -p -r1.2 gnu-debugdata.exp --- gdb/testsuite/gdb.base/gnu-debugdata.exp 29 Nov 2012 20:53:24 -0000 1.2 +++ gdb/testsuite/gdb.base/gnu-debugdata.exp 5 Dec 2012 17:05:02 -0000 @@ -95,10 +95,12 @@ if {[pipeline "nm -D" \ } # Extract all the text (i.e. function) symbols from the debuginfo. +# (Note that we actually also accept "D" symbols, for the benefit +# of platforms like PowerPC64 that use function descriptors.) remote_file host delete ${binfile}.funcsyms if {[pipeline "nm" \ [list [transform nm] "${binfile} --format=posix --defined-only"] \ - [list awk "\\{if(\\\$2==\"T\"||\\\$2==\"t\")print\\ \\\$1\\}"] \ + [list awk "\\{if(\\\$2==\"T\"||\\\$2==\"t\"||\\\$2==\"D\")print\\ \\\$1\\}"] \ [list sort "" "" "${binfile}.funcsyms"]]} { return -1 } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com