From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/Ada 1/4] Full view of interface-wide types
Date: Thu, 29 Nov 2012 14:20:00 -0000 [thread overview]
Message-ID: <20121129141954.GE3581@adacore.com> (raw)
In-Reply-To: <1354196235-8414-1-git-send-email-guitton@adacore.com>
> gdb/ChangeLog:
>
> * ada-lang.h (ada_tag_value_at_base_address): New function
> declaration.
> * ada-lang.c (is_ada95_tag, ada_tag_value_at_base_address):
> New functions.
> (ada_to_fixed_type_1, ada_evaluate_subexp): Let ada_tag_base_address
> relocate the class-wide value if need be.
> * (ada_value_struct_elt, ada_value_ind, ada_coerce_ref):
> Let ada_tag_value_at_base_address relocate the class-wide access/ref
> before dereferencing it.
> * ada-valprint.c (ada_val_print_1): Relocate to base address
> before displaying the content of a interface-wide ref.
OK! Small nit: "an interface-wide ref" (instead of "a" - last line
of the ChangeLog entry).
--
Joel
prev parent reply other threads:[~2012-11-29 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:37 Jerome Guitton
2012-11-29 13:37 ` [RFA/testsuite 4/4] update ptype_tagged_param.exp Jerome Guitton
2012-11-29 14:22 ` Joel Brobecker
2012-11-29 16:36 ` Jerome Guitton
2012-11-29 13:37 ` [RFA/Ada 2/4] Strip interface tags from visible fields Jerome Guitton
2012-11-29 14:20 ` Joel Brobecker
2012-11-29 13:37 ` [RFA/testsuite 3/4] New testcase for interface type printing Jerome Guitton
2012-11-29 14:20 ` Joel Brobecker
2012-11-29 14:20 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129141954.GE3581@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox