From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19067 invoked by alias); 29 Nov 2012 14:20:08 -0000 Received: (qmail 19044 invoked by uid 22791); 29 Nov 2012 14:20:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 14:19:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 69D2D2E0A8; Thu, 29 Nov 2012 09:19:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gmXg-uSqFxgK; Thu, 29 Nov 2012 09:19:56 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3A0681C7AA6; Thu, 29 Nov 2012 09:19:56 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 385E6C0359; Thu, 29 Nov 2012 15:19:54 +0100 (CET) Date: Thu, 29 Nov 2012 14:20:00 -0000 From: Joel Brobecker To: Jerome Guitton Cc: gdb-patches@sourceware.org Subject: Re: [RFA/Ada 1/4] Full view of interface-wide types Message-ID: <20121129141954.GE3581@adacore.com> References: <1354196235-8414-1-git-send-email-guitton@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1354196235-8414-1-git-send-email-guitton@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00859.txt.bz2 > gdb/ChangeLog: > > * ada-lang.h (ada_tag_value_at_base_address): New function > declaration. > * ada-lang.c (is_ada95_tag, ada_tag_value_at_base_address): > New functions. > (ada_to_fixed_type_1, ada_evaluate_subexp): Let ada_tag_base_address > relocate the class-wide value if need be. > * (ada_value_struct_elt, ada_value_ind, ada_coerce_ref): > Let ada_tag_value_at_base_address relocate the class-wide access/ref > before dereferencing it. > * ada-valprint.c (ada_val_print_1): Relocate to base address > before displaying the content of a interface-wide ref. OK! Small nit: "an interface-wide ref" (instead of "a" - last line of the ChangeLog entry). -- Joel