Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
@ 2012-11-07  8:46 Pierre Muller
  2012-11-07 15:07 ` Joel Brobecker
  0 siblings, 1 reply; 8+ messages in thread
From: Pierre Muller @ 2012-11-07  8:46 UTC (permalink / raw)
  To: gdb-patches, 'Joel Brobecker', 'Tom Tromey'

  The idea of adding the ARI scripts to CVS sources
was twofold:
1) That everyone should be able to generate local ARI web page
to check if local diffs do generate changes in ARI.

2) Allow the main GDB web site to use ARI scripts adapted to current CVS 
changes.

  For point #2, we need to test
the generation of ARI web pages on sourceware.org server.

  This is the purpose of the change below, after suggestions from Joel.
For now, it just adds a new directory on the sourceware.org web server
http://sourceware.org/gdb/current/ari/test

  The ARI web pages accessible from the GDB web site
are not affected by that change.

  Things that probably will need some adjustments are 
links between different ARI versions...(But those are 
already post-processed in the current setup).


Pierre Muller


~/ss % diff -u do-snapshot test-do-snapshot
--- do-snapshot 2012-11-06 16:33:41.000000000 +0000
+++ test-do-snapshot    2012-11-07 08:29:37.000000000 +0000
@@ -92,6 +92,25 @@
     tail -50 ${logfile} | mail -s "update-web-ari ${package} ${ftp} failed"
brobecke
 fi

+# Check if source checkout contains also the update-web-ari script
+cvs_ari_script="${tempdir}/update-web-ari/gdb-${version}/gdb/contrib/ari/up
date-web-ari.sh"
+if test -f  "${cvs_ari_script}"
+then
+  # For now also run this script, but put results in ari/test subdirectory
+  if ( set -x ; sh ${cvs_ari_script} \
+       ${snapdir}/${package}-${version}.tar \
+       ${tmpdir}/update-web-ari \
+       ${wwwdir}/ari/test \
+       gdb \
+       >> ${logfile} )
+  then
+      echo "update-web-ari from CVS sources ${package} ${ftp} done"
+  else
+      tail -50 ${logfile} | mail -s "update-web-ari from sources ${package}
${ftp} failed" brobecke
+  fi
+fi
+
+


 ( echo "" ; date ; echo "" ) | tee -a ${logfile}


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-07  8:46 [RFC] Create also ARI web page using CVS source in gdb/contrib/ari Pierre Muller
@ 2012-11-07 15:07 ` Joel Brobecker
  2012-11-07 16:15   ` Pierre Muller
  0 siblings, 1 reply; 8+ messages in thread
From: Joel Brobecker @ 2012-11-07 15:07 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches, 'Tom Tromey'

>   This is the purpose of the change below, after suggestions from Joel.
> For now, it just adds a new directory on the sourceware.org web server
> http://sourceware.org/gdb/current/ari/test

As said privately, it is fine to have a temporary staging area for
testing the new ARI scripts. In the interest of allowing you to make
progress a little faster, please feel free also to self-approve changes
that you feel confident about. (we're always quite happy to provide
feedback whenever you feel necessary, of course, and we will send
comments if there is something we notice).

Cheers,
-- 
Joel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-07 15:07 ` Joel Brobecker
@ 2012-11-07 16:15   ` Pierre Muller
  2012-11-07 16:25     ` Joel Brobecker
  2012-11-08  8:57     ` Pierre Muller
  0 siblings, 2 replies; 8+ messages in thread
From: Pierre Muller @ 2012-11-07 16:15 UTC (permalink / raw)
  To: 'Joel Brobecker'; +Cc: gdb-patches, 'Tom Tromey'

  OK,
  I committed the change to ss CVS directory,
the gdbadmin ss directory is also update, which means that
the first ari/test/index.html should be generated tonight.

  If anything goes wrong, you are going to get the email...
If that happens, could you please forward it to me?




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : mercredi 7 novembre 2012 16:07
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Tom Tromey'
> Objet : Re: [RFC] Create also ARI web page using CVS source in
> gdb/contrib/ari
> 
> >   This is the purpose of the change below, after suggestions from Joel.
> > For now, it just adds a new directory on the sourceware.org web server
> > http://sourceware.org/gdb/current/ari/test
> 
> As said privately, it is fine to have a temporary staging area for
> testing the new ARI scripts. In the interest of allowing you to make
> progress a little faster, please feel free also to self-approve changes
> that you feel confident about. (we're always quite happy to provide
> feedback whenever you feel necessary, of course, and we will send
> comments if there is something we notice).

  I will send a first bunch of fixes shortly...
Mainly about ChangeLog formatting issues as usual...

Pierre


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-07 16:15   ` Pierre Muller
@ 2012-11-07 16:25     ` Joel Brobecker
  2012-11-07 16:30       ` Pierre Muller
  2012-11-08  8:57     ` Pierre Muller
  1 sibling, 1 reply; 8+ messages in thread
From: Joel Brobecker @ 2012-11-07 16:25 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches, 'Tom Tromey'

>   If anything goes wrong, you are going to get the email...
> If that happens, could you please forward it to me?

Most definitely :-). Or you can add yourself as well as an extra
recipient.

-- 
Joel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-07 16:25     ` Joel Brobecker
@ 2012-11-07 16:30       ` Pierre Muller
  0 siblings, 0 replies; 8+ messages in thread
From: Pierre Muller @ 2012-11-07 16:30 UTC (permalink / raw)
  To: 'Joel Brobecker'; +Cc: gdb-patches, 'Tom Tromey'

  OK, I added my email address also
directly on gdbadmin account.

Pierre

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : mercredi 7 novembre 2012 17:25
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Tom Tromey'
> Objet : Re: [RFC] Create also ARI web page using CVS source in
> gdb/contrib/ari
> 
> >   If anything goes wrong, you are going to get the email...
> > If that happens, could you please forward it to me?
> 
> Most definitely :-). Or you can add yourself as well as an extra
> recipient.
> 
> --
> Joel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-07 16:15   ` Pierre Muller
  2012-11-07 16:25     ` Joel Brobecker
@ 2012-11-08  8:57     ` Pierre Muller
  2012-11-08 16:14       ` Joel Brobecker
  1 sibling, 1 reply; 8+ messages in thread
From: Pierre Muller @ 2012-11-08  8:57 UTC (permalink / raw)
  To: 'Joel Brobecker'; +Cc: gdb-patches, 'Tom Tromey'

  The current change doesn't work because the
whole checked out sources gets removed at the end of the
update-web-ari
not the end of the script, but the trap command, which is

~/ss % grep -n trap   update-web-ari
71:    trap "cd /tmp; rm -rf ${tmpdir}; exit" 0 1 2 15

  Should I modify ss/update-web-ari so that it
generate a temp-file that reports if the CVS sources
contain a contrib/ari/update-web-ari.sh file
and prevent tempdir deletion in that case?

  Any cleaner solution welcome,


  Pierre Muller


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : mercredi 7 novembre 2012 17:15
> À : 'Joel Brobecker'
> Cc : gdb-patches@sourceware.org; 'Tom Tromey'
> Objet : RE: [RFC] Create also ARI web page using CVS source in
> gdb/contrib/ari
> 
>   OK,
>   I committed the change to ss CVS directory,
> the gdbadmin ss directory is also update, which means that
> the first ari/test/index.html should be generated tonight.
> 
>   If anything goes wrong, you are going to get the email...
> If that happens, could you please forward it to me?
> 
> 
> 
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Joel Brobecker
> > Envoyé : mercredi 7 novembre 2012 16:07
> > À : Pierre Muller
> > Cc : gdb-patches@sourceware.org; 'Tom Tromey'
> > Objet : Re: [RFC] Create also ARI web page using CVS source in
> > gdb/contrib/ari
> >
> > >   This is the purpose of the change below, after suggestions from
Joel.
> > > For now, it just adds a new directory on the sourceware.org web server
> > > http://sourceware.org/gdb/current/ari/test
> >
> > As said privately, it is fine to have a temporary staging area for
> > testing the new ARI scripts. In the interest of allowing you to make
> > progress a little faster, please feel free also to self-approve changes
> > that you feel confident about. (we're always quite happy to provide
> > feedback whenever you feel necessary, of course, and we will send
> > comments if there is something we notice).
> 
>   I will send a first bunch of fixes shortly...
> Mainly about ChangeLog formatting issues as usual...
> 
> Pierre



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-08  8:57     ` Pierre Muller
@ 2012-11-08 16:14       ` Joel Brobecker
  2012-11-08 16:29         ` Pierre Muller
  0 siblings, 1 reply; 8+ messages in thread
From: Joel Brobecker @ 2012-11-08 16:14 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches, 'Tom Tromey'

Hi Pierre,

>   Should I modify ss/update-web-ari so that it generate a temp-file
>   that reports if the CVS sources contain a
>   contrib/ari/update-web-ari.sh file and prevent tempdir deletion in
>   that case?

What I would probably do is perform the ARI generation in a non-temporary
directory of our choosing. I don't think we should turn the cleanup off,
because we'll start leaving a lot of data behind each day.

-- 
Joel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RFC] Create also ARI web page using CVS source in gdb/contrib/ari
  2012-11-08 16:14       ` Joel Brobecker
@ 2012-11-08 16:29         ` Pierre Muller
  0 siblings, 0 replies; 8+ messages in thread
From: Pierre Muller @ 2012-11-08 16:29 UTC (permalink / raw)
  To: 'Joel Brobecker'; +Cc: gdb-patches, 'Tom Tromey'

  I finally managed to generate a web page:
http://sourceware.org/gdb/current/ari/test/

  I just left the data corresponding to the
extraction of the tarball in place,
but I don't think that the data will grow,
as the nightly script contains some code that 
clean the temp dir at a higher level.

Pierre

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : jeudi 8 novembre 2012 17:14
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Tom Tromey'
> Objet : Re: [RFC] Create also ARI web page using CVS source in
> gdb/contrib/ari
> 
> Hi Pierre,
> 
> >   Should I modify ss/update-web-ari so that it generate a temp-file
> >   that reports if the CVS sources contain a
> >   contrib/ari/update-web-ari.sh file and prevent tempdir deletion in
> >   that case?
> 
> What I would probably do is perform the ARI generation in a non-temporary
> directory of our choosing. I don't think we should turn the cleanup off,
> because we'll start leaving a lot of data behind each day.
> 
> --
> Joel


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-11-08 16:29 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-07  8:46 [RFC] Create also ARI web page using CVS source in gdb/contrib/ari Pierre Muller
2012-11-07 15:07 ` Joel Brobecker
2012-11-07 16:15   ` Pierre Muller
2012-11-07 16:25     ` Joel Brobecker
2012-11-07 16:30       ` Pierre Muller
2012-11-08  8:57     ` Pierre Muller
2012-11-08 16:14       ` Joel Brobecker
2012-11-08 16:29         ` Pierre Muller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox