From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>, GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR binutils/14813: Wrong return type for opncls_bclose
Date: Wed, 07 Nov 2012 07:31:00 -0000 [thread overview]
Message-ID: <20121107073048.GS31965@bubble.grove.modra.org> (raw)
In-Reply-To: <CAMe9rOrq7QNfMk6cBtN37TtNHCo-wQ83CbNM9r1GsHqsB8qWCg@mail.gmail.com>
On Tue, Nov 06, 2012 at 09:34:23PM -0800, H.J. Lu wrote:
> On Tue, Nov 6, 2012 at 5:07 PM, Alan Modra <amodra@gmail.com> wrote:
> > On Tue, Nov 06, 2012 at 04:30:07PM -0800, H.J. Lu wrote:
> >> Hi,
> >>
> >> This patch changes return type of bclose to bfd_boolean. It fixes
> >> binutils/bfdtest2. OK to install?
> >
> > Not without checking gdb code too.
> >
>
> Sure. Here is the GDB patch. OK to install?
No, gdb is fine as is. When I saw your change I grepped for bfd_iovec
and hit a number of places in gdb, which is why I commented about
checking gdb. It turns out that none of these have anything to do
with your change to struct bfd_iovec.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2012-11-07 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121107003007.GA8682@gmail.com>
[not found] ` <20121107010714.GQ31965@bubble.grove.modra.org>
2012-11-07 5:34 ` H.J. Lu
2012-11-07 7:31 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107073048.GS31965@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox