From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31378 invoked by alias); 7 Nov 2012 07:31:02 -0000 Received: (qmail 31354 invoked by uid 22791); 7 Nov 2012 07:31:00 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Nov 2012 07:30:55 +0000 Received: by mail-pa0-f41.google.com with SMTP id fa10so1019918pad.0 for ; Tue, 06 Nov 2012 23:30:54 -0800 (PST) Received: by 10.68.248.74 with SMTP id yk10mr4620210pbc.86.1352273454562; Tue, 06 Nov 2012 23:30:54 -0800 (PST) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPS id mt15sm13700339pbc.49.2012.11.06.23.30.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Nov 2012 23:30:53 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 01478EA341D; Wed, 7 Nov 2012 18:00:48 +1030 (CST) Date: Wed, 07 Nov 2012 07:31:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: Binutils , GDB Subject: Re: PATCH: PR binutils/14813: Wrong return type for opncls_bclose Message-ID: <20121107073048.GS31965@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , Binutils , GDB References: <20121107003007.GA8682@gmail.com> <20121107010714.GQ31965@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00135.txt.bz2 On Tue, Nov 06, 2012 at 09:34:23PM -0800, H.J. Lu wrote: > On Tue, Nov 6, 2012 at 5:07 PM, Alan Modra wrote: > > On Tue, Nov 06, 2012 at 04:30:07PM -0800, H.J. Lu wrote: > >> Hi, > >> > >> This patch changes return type of bclose to bfd_boolean. It fixes > >> binutils/bfdtest2. OK to install? > > > > Not without checking gdb code too. > > > > Sure. Here is the GDB patch. OK to install? No, gdb is fine as is. When I saw your change I grepped for bfd_iovec and hit a number of places in gdb, which is why I commented about checking gdb. It turns out that none of these have anything to do with your change to struct bfd_iovec. -- Alan Modra Australia Development Lab, IBM