Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] dangling bfd pointer in archive cache...
Date: Tue, 16 Oct 2012 22:58:00 -0000	[thread overview]
Message-ID: <20121016225842.GI3050@adacore.com> (raw)
In-Reply-To: <20121016014805.GI4541@bubble.grove.modra.org>

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

> On Mon, Oct 15, 2012 at 11:00:52AM -0700, Joel Brobecker wrote:
> >         * coff-rs6000.c (rs6000coff_vec): Set _close_and_cleanup
> >         field to _bfd_archive_close_and_cleanup.
> >         (pmac_xcoff_vec): Likewise.
> 
> OK.  Please apply the same fix to coff64-rs6000.c.

Thanks. Checked in (attached is the patch applied to coff64-rs6000.c).

-- 
Joel

[-- Attachment #2: 0001-dangling-pointer-in-coff64-rs6000-archive-cache.patch --]
[-- Type: text/x-diff, Size: 1070 bytes --]

From ecaaf1440801831e107c39fea3016e2e57cc507c Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Tue, 16 Oct 2012 15:51:13 -0700
Subject: [PATCH] dangling pointer in coff64-rs6000 archive cache.

bfd/ChangeLog:

        * coff64-rs6000.c (rs6000coff64_vec): Set _close_and_cleanup
        field to _bfd_archive_close_and_cleanup.
        (aix5coff64_vec): Likewise.
---
 bfd/coff64-rs6000.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bfd/coff64-rs6000.c b/bfd/coff64-rs6000.c
index 0821b6f..5f4a502 100644
--- a/bfd/coff64-rs6000.c
+++ b/bfd/coff64-rs6000.c
@@ -2668,7 +2668,7 @@ const bfd_target rs6000coff64_vec =
     },
 
     /* Generic */
-    bfd_true,
+    _bfd_archive_close_and_cleanup,
     bfd_true,
     coff_new_section_hook,
     _bfd_generic_get_section_contents,
@@ -2926,7 +2926,7 @@ const bfd_target aix5coff64_vec =
     },
 
     /* Generic */
-    bfd_true,
+    _bfd_archive_close_and_cleanup,
     bfd_true,
     coff_new_section_hook,
     _bfd_generic_get_section_contents,
-- 
1.7.9.5


      reply	other threads:[~2012-10-16 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 14:14 Joel Brobecker
2012-10-03  5:29 ` Alan Modra
2012-10-03 13:30   ` Joel Brobecker
2012-10-04  8:01     ` Alan Modra
2012-10-15 18:01   ` Joel Brobecker
2012-10-16  1:48     ` Alan Modra
2012-10-16 22:58       ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016225842.GI3050@adacore.com \
    --to=brobecker@adacore.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox