From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22203 invoked by alias); 16 Oct 2012 22:58:55 -0000 Received: (qmail 22181 invoked by uid 22791); 16 Oct 2012 22:58:54 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Oct 2012 22:58:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 213971C7A77; Tue, 16 Oct 2012 18:58:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AQP97CyAIooN; Tue, 16 Oct 2012 18:58:49 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DBB5C1C79D5; Tue, 16 Oct 2012 18:58:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6FFF1C4B79; Tue, 16 Oct 2012 15:58:42 -0700 (PDT) Date: Tue, 16 Oct 2012 22:58:00 -0000 From: Joel Brobecker To: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [RFC/RFA] dangling bfd pointer in archive cache... Message-ID: <20121016225842.GI3050@adacore.com> References: <20121002141405.GD3028@adacore.com> <20121003052937.GB25219@bubble.grove.modra.org> <20121015180052.GF3050@adacore.com> <20121016014805.GI4541@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="aVD9QWMuhilNxW9f" Content-Disposition: inline In-Reply-To: <20121016014805.GI4541@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00264.txt.bz2 --aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 366 > On Mon, Oct 15, 2012 at 11:00:52AM -0700, Joel Brobecker wrote: > > * coff-rs6000.c (rs6000coff_vec): Set _close_and_cleanup > > field to _bfd_archive_close_and_cleanup. > > (pmac_xcoff_vec): Likewise. > > OK. Please apply the same fix to coff64-rs6000.c. Thanks. Checked in (attached is the patch applied to coff64-rs6000.c). -- Joel --aVD9QWMuhilNxW9f Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-dangling-pointer-in-coff64-rs6000-archive-cache.patch" Content-length: 1071 >From ecaaf1440801831e107c39fea3016e2e57cc507c Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 16 Oct 2012 15:51:13 -0700 Subject: [PATCH] dangling pointer in coff64-rs6000 archive cache. bfd/ChangeLog: * coff64-rs6000.c (rs6000coff64_vec): Set _close_and_cleanup field to _bfd_archive_close_and_cleanup. (aix5coff64_vec): Likewise. --- bfd/coff64-rs6000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bfd/coff64-rs6000.c b/bfd/coff64-rs6000.c index 0821b6f..5f4a502 100644 --- a/bfd/coff64-rs6000.c +++ b/bfd/coff64-rs6000.c @@ -2668,7 +2668,7 @@ const bfd_target rs6000coff64_vec = }, /* Generic */ - bfd_true, + _bfd_archive_close_and_cleanup, bfd_true, coff_new_section_hook, _bfd_generic_get_section_contents, @@ -2926,7 +2926,7 @@ const bfd_target aix5coff64_vec = }, /* Generic */ - bfd_true, + _bfd_archive_close_and_cleanup, bfd_true, coff_new_section_hook, _bfd_generic_get_section_contents, -- 1.7.9.5 --aVD9QWMuhilNxW9f--