From: Joel Brobecker <brobecker@adacore.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Expand variables to accommodate LONGEST enumval
Date: Mon, 24 Sep 2012 10:12:00 -0000 [thread overview]
Message-ID: <20120924101222.GC4146@adacore.com> (raw)
In-Reply-To: <20120924152250.42bb17fa@spoyarek>
> gdb/ChangeLog:
>
> * m2-typeprint.c (m2_enum): Expand LASTVAL to LONGEST.
> * p-valprint.c (pascal_type_print_base): Likewise.
Looks good to me. I am overstepping my bounds a little, but for such
a small change, I think it'll be OK.
Looking at the code, I think that the variable definitions can be moved
inside the block where they are actually used. But that's for another
patch.
--
Joel
next prev parent reply other threads:[~2012-09-24 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 9:53 Siddhesh Poyarekar
2012-09-24 10:12 ` Joel Brobecker [this message]
2012-09-24 10:25 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924101222.GC4146@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox