From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32181 invoked by alias); 24 Sep 2012 10:12:44 -0000 Received: (qmail 32164 invoked by uid 22791); 24 Sep 2012 10:12:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 10:12:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A82CD1C7916; Mon, 24 Sep 2012 06:12:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fNSdlvn8V2aa; Mon, 24 Sep 2012 06:12:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5EC451C7912; Mon, 24 Sep 2012 06:12:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0476BCCCDD; Mon, 24 Sep 2012 12:12:22 +0200 (CEST) Date: Mon, 24 Sep 2012 10:12:00 -0000 From: Joel Brobecker To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Expand variables to accommodate LONGEST enumval Message-ID: <20120924101222.GC4146@adacore.com> References: <20120924152250.42bb17fa@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120924152250.42bb17fa@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00491.txt.bz2 > gdb/ChangeLog: > > * m2-typeprint.c (m2_enum): Expand LASTVAL to LONGEST. > * p-valprint.c (pascal_type_print_base): Likewise. Looks good to me. I am overstepping my bounds a little, but for such a small change, I think it'll be OK. Looking at the code, I think that the variable definitions can be moved inside the block where they are actually used. But that's for another patch. -- Joel