From: Joel Brobecker <brobecker@adacore.com>
To: swamy sangamesh <swamy.sangamesh@gmail.com>
Cc: "Abid, Hafiz" <Hafiz_Abid@mentor.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: AIX 64bit support
Date: Tue, 21 Aug 2012 15:40:00 -0000 [thread overview]
Message-ID: <20120821153953.GU2798@adacore.com> (raw)
In-Reply-To: <CAL5y1_jMf75MDBH5=aZRMFFaw0KEWCfWnSX24xy+PS4HtTQ=Fg@mail.gmail.com>
> Let me know if we can do #ifdef check in a macro and call the marco as
> mentioned below would be feasible to reduce the many #ifdef checks ?
>
>
> macro for ptrace64aix
>
> #define ptrace_check_64aix(req, tid, addr, data, buff) \
> #ifdef BFD64 \
> if (!ptrace64aix (req, (long long) tid, \
> (long long) addr, data, buff)) \
> #else \
> if (!ptrace64aix (req, tid, \
> (unsigned long) addr, data, buff)) \
> #endif \
Can you please instead make those functions instead? It will make
the code much easier to understand, IMO.
--
Joel
next prev parent reply other threads:[~2012-08-21 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 8:23 swamy sangamesh
2012-08-09 9:01 ` Abid, Hafiz
2012-08-21 11:33 ` swamy sangamesh
2012-08-21 15:40 ` Joel Brobecker [this message]
2012-08-23 20:13 ` Tom Tromey
2012-08-23 20:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821153953.GU2798@adacore.com \
--to=brobecker@adacore.com \
--cc=Hafiz_Abid@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=swamy.sangamesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox