From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93945-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28482 invoked by alias); 21 Aug 2012 15:40:19 -0000
Received: (qmail 28417 invoked by uid 22791); 21 Aug 2012 15:40:18 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Aug 2012 15:40:05 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 122551C77B5;	Tue, 21 Aug 2012 11:40:05 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id PgbdVUlc7pLO; Tue, 21 Aug 2012 11:40:05 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 9C6E01C77E7;	Tue, 21 Aug 2012 11:40:03 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id D475114561A; Tue, 21 Aug 2012 08:39:53 -0700 (PDT)
Date: Tue, 21 Aug 2012 15:40:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: swamy sangamesh <swamy.sangamesh@gmail.com>
Cc: "Abid, Hafiz" <Hafiz_Abid@mentor.com>,	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: AIX 64bit support
Message-ID: <20120821153953.GU2798@adacore.com>
References: <CAL5y1_hO5yDeB0e0oJSfE4THZDcm7JDKjwZhfKOgE2pmYFqZKA@mail.gmail.com> <EB3B29AD43CA924DA27099BC851923762A1A5F@EU-MBX-03.mgc.mentorg.com> <CAL5y1_jMf75MDBH5=aZRMFFaw0KEWCfWnSX24xy+PS4HtTQ=Fg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL5y1_jMf75MDBH5=aZRMFFaw0KEWCfWnSX24xy+PS4HtTQ=Fg@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00574.txt.bz2

> Let me know if we can do #ifdef check in a macro and call the marco as
> mentioned below would be feasible to reduce the many #ifdef checks ?
> 
> 
> macro for ptrace64aix
> 
> #define ptrace_check_64aix(req, tid, addr, data, buff) \
>     #ifdef BFD64 \
>     if (!ptrace64aix (req, (long long) tid, \
>                      (long long) addr, data, buff)) \
>      #else \
>     if (!ptrace64aix (req, tid, \
>  			    (unsigned long) addr, data, buff)) \
>     #endif \

Can you please instead make those functions instead? It will make
the code much easier to understand, IMO.


-- 
Joel