From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [obv] Handle var_string_noescape and var_optional_filename together.
Date: Wed, 18 Jul 2012 13:57:00 -0000 [thread overview]
Message-ID: <20120718135655.GB10378@host2.jankratochvil.net> (raw)
In-Reply-To: <1342636814-1674-1-git-send-email-yao@codesourcery.com>
On Wed, 18 Jul 2012 20:40:14 +0200, Yao Qi wrote:
> I notice that the code in case var_string_noescape and var_optional_filename
> are exactly the same, so this patch is to combine them together. I'll commit
> it in two days.
I do not agree, this will hide an existing bug.
Correct it to fix var_optional_filename to be more like var_filename (clearing
whitespaces + doing tilde_expand); except sure without that:
if (arg == NULL)
error_no_arg (_("filename to set it to."));
Thanks,
Jan
next prev parent reply other threads:[~2012-07-18 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 12:41 Yao Qi
2012-07-18 13:57 ` Jan Kratochvil [this message]
2012-07-18 14:59 ` Yao Qi
2012-07-18 15:26 ` Jan Kratochvil
2012-07-19 7:54 ` [committed]:[obv] " Yao Qi
2012-07-19 7:58 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718135655.GB10378@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox