From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21989 invoked by alias); 18 Jul 2012 13:57:25 -0000 Received: (qmail 21978 invoked by uid 22791); 18 Jul 2012 13:57:24 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 13:57:05 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6IDv187016048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Jul 2012 09:57:01 -0400 Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6IDuvxJ013788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 18 Jul 2012 09:57:00 -0400 Date: Wed, 18 Jul 2012 13:57:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [obv] Handle var_string_noescape and var_optional_filename together. Message-ID: <20120718135655.GB10378@host2.jankratochvil.net> References: <1342636814-1674-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342636814-1674-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00261.txt.bz2 On Wed, 18 Jul 2012 20:40:14 +0200, Yao Qi wrote: > I notice that the code in case var_string_noescape and var_optional_filename > are exactly the same, so this patch is to combine them together. I'll commit > it in two days. I do not agree, this will hide an existing bug. Correct it to fix var_optional_filename to be more like var_filename (clearing whitespaces + doing tilde_expand); except sure without that: if (arg == NULL) error_no_arg (_("filename to set it to.")); Thanks, Jan