From: Gary Benson <gbenson@redhat.com>
To: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] MI telnet service
Date: Thu, 12 Jul 2012 15:08:00 -0000 [thread overview]
Message-ID: <20120712150819.GA25265@redhat.com> (raw)
In-Reply-To: <EB3B29AD43CA924DA27099BC8519237629DFEA@EU-MBX-03.mgc.mentorg.com>
Abid, Hafiz wrote:
> Gary Benson wrote:
> > > diff -N gdb/testsuite/gdb.mi/mi-telnet.c
> > > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > > +++ gdb/testsuite/gdb.mi/mi-telnet.c 12 Jul 2012 10:35:17 -0000
> >
> > The indentation in this file is completely wrong. There's also
> > a lot of missing space before '(' for function calls and missing
> > space after casts.
>
> I thought we are not required to follow the convention in the test
> program source.
Ah, possibly. Perhaps someone more familiar could comment?
> Thanks for reviewing.
No problem :)
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2012-07-12 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 11:21 Abid, Hafiz
2012-07-12 13:19 ` Gary Benson
2012-07-12 14:37 ` Abid, Hafiz
2012-07-12 15:08 ` Gary Benson [this message]
2012-07-15 8:13 ` Jan Kratochvil
2012-07-12 13:29 ` Eli Zaretskii
2012-07-12 14:45 ` Abid, Hafiz
2012-07-14 19:37 ` Marc Khouzam
2012-07-24 16:17 ` Abid, Hafiz
2012-07-24 19:06 ` Marc Khouzam
2012-07-24 20:15 ` Marc Khouzam
2012-07-17 17:53 ` Vladimir Prus
2012-07-25 13:02 ` Jan Kratochvil
2012-07-25 14:12 ` Marc Khouzam
2012-07-25 19:27 ` Jan Kratochvil
2012-07-26 0:02 ` Stan Shebs
2012-07-26 11:51 ` Jan Kratochvil
2012-08-03 11:36 ` Jan Kratochvil
2012-07-25 14:16 ` Abid, Hafiz
2012-07-25 19:29 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712150819.GA25265@redhat.com \
--to=gbenson@redhat.com \
--cc=Hafiz_Abid@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox