From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2708 invoked by alias); 12 Jul 2012 15:08:44 -0000 Received: (qmail 2689 invoked by uid 22791); 12 Jul 2012 15:08:42 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jul 2012 15:08:22 +0000 Date: Thu, 12 Jul 2012 15:08:00 -0000 From: Gary Benson To: "Abid, Hafiz" Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] MI telnet service Message-ID: <20120712150819.GA25265@redhat.com> Mail-Followup-To: "Abid, Hafiz" , "gdb-patches@sourceware.org" References: <20120712131930.GG29236@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00164.txt.bz2 Abid, Hafiz wrote: > Gary Benson wrote: > > > diff -N gdb/testsuite/gdb.mi/mi-telnet.c > > > --- /dev/null 1 Jan 1970 00:00:00 -0000 > > > +++ gdb/testsuite/gdb.mi/mi-telnet.c 12 Jul 2012 10:35:17 -0000 > > > > The indentation in this file is completely wrong. There's also > > a lot of missing space before '(' for function calls and missing > > space after casts. > > I thought we are not required to follow the convention in the test > program source. Ah, possibly. Perhaps someone more familiar could comment? > Thanks for reviewing. No problem :) Cheers, Gary -- http://gbenson.net/