Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: tromey@redhat.com, gdb-patches@sourceware.org
Subject: [RFC] psymtab.c (map_symbol_filenames_psymtab): Skip shared psymtabs.
Date: Tue, 10 Jul 2012 20:57:00 -0000	[thread overview]
Message-ID: <20120710205721.BF5DA1E1280@ruffy2.mtv.corp.google.com> (raw)

Hi.

I don't know if this patch is correct or not.
It looked odd that partial_map_symtabs_matching_filename
and expand_symtabs_matching_via_partial skip shared symtabs but
map_symbol_filenames_psymtab does not.

2012-07-10  Doug Evans  <dje@google.com>

	* psymtab.c (map_symbol_filenames_psymtab): Skip shared psymtabs.

Index: psymtab.c
===================================================================
RCS file: /cvs/src/src/gdb/psymtab.c,v
retrieving revision 1.50
diff -u -p -r1.50 psymtab.c
--- psymtab.c	10 Jul 2012 20:17:30 -0000	1.50
+++ psymtab.c	10 Jul 2012 20:53:14 -0000
@@ -1159,6 +1159,11 @@ map_symbol_filenames_psymtab (struct obj
       if (ps->readin)
 	continue;
 
+      /* We can skip shared psymtabs here, because any file name will be
+	 attached to the unshared psymtab.  */
+      if (ps->user != NULL)
+	continue;
+
       /* Anonymous psymtabs don't have a file name.  */
       if (ps->anonymous)
 	continue;


             reply	other threads:[~2012-07-10 20:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 20:57 Doug Evans [this message]
2012-07-11 14:10 ` Tom Tromey
2012-07-12 21:16   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120710205721.BF5DA1E1280@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox