From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6842 invoked by alias); 10 Jul 2012 20:57:38 -0000 Received: (qmail 6830 invoked by uid 22791); 10 Jul 2012 20:57:36 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f201.google.com (HELO mail-vc0-f201.google.com) (209.85.220.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 20:57:23 +0000 Received: by vcqp1 with SMTP id p1so51572vcq.0 for ; Tue, 10 Jul 2012 13:57:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:message-id:date:from:x-gm-message-state; bh=A0GwBLR66eKZ7hLhWuSB3al05Nrqcv04QMZgoLeGDkw=; b=QSJd5If02/t867fK63MQ5ny/4xWCkQqRDLNHLt19nkFGNeSBaMNJUMgJoOCIw7K5z7 zxflDc8soSEYK2y1Ho+IFCiWrdMSx2fElJ8dA38UDEsxDXZjKOZdxi3s71KaKGK92jG3 Wi6qSkvg8RVYA0t2kRWziFHURkOZkic3rLnU/4amuGfA0tzeGn+WplUdDVrZcRf4LyBN WssI5dTKyhOwnYqBS09kr+/BhebVoFy3agrOrr3dTHNueGPBUYXHe6Ww5lKMUSQIVyDw DS5RVRHBQ3gIaI5oHbwbS4rm8Ubv+M62yKpvuQWcdhpOoolVWChtrq+XUtxpOj18Qc1l 61aQ== Received: by 10.236.189.36 with SMTP id b24mr32351370yhn.9.1341953842282; Tue, 10 Jul 2012 13:57:22 -0700 (PDT) Received: by 10.236.189.36 with SMTP id b24mr32351361yhn.9.1341953842241; Tue, 10 Jul 2012 13:57:22 -0700 (PDT) Received: from wpzn4.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id k67si9308993yhm.2.2012.07.10.13.57.22 (version=TLSv1/SSLv3 cipher=AES128-SHA); Tue, 10 Jul 2012 13:57:22 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.18.110.129]) by wpzn4.hot.corp.google.com (Postfix) with ESMTP id 26C431E005D; Tue, 10 Jul 2012 13:57:22 -0700 (PDT) Received: by ruffy2.mtv.corp.google.com (Postfix, from userid 67641) id BF5DA1E1280; Tue, 10 Jul 2012 13:57:21 -0700 (PDT) To: tromey@redhat.com, gdb-patches@sourceware.org Subject: [RFC] psymtab.c (map_symbol_filenames_psymtab): Skip shared psymtabs. Message-Id: <20120710205721.BF5DA1E1280@ruffy2.mtv.corp.google.com> Date: Tue, 10 Jul 2012 20:57:00 -0000 From: dje@google.com (Doug Evans) X-Gm-Message-State: ALoCoQkU55y5UPdwhrO6c2a9bWsx84zl2IfvGlweafycuJ0dWpAqf//AxFJJdecD4n+4c6YfwKwX/8CBb/xmsHAuFveWxiCPsRK7WdTRWSFpdtHe+K1BaJYNiZuRcVLdv4W/D0AMAnxnv6yuUAobteIrQom4V2wqfaW4HxDczok8/K72XL9NfpXool5dCtcCe2q18HDER8pu X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00144.txt.bz2 Hi. I don't know if this patch is correct or not. It looked odd that partial_map_symtabs_matching_filename and expand_symtabs_matching_via_partial skip shared symtabs but map_symbol_filenames_psymtab does not. 2012-07-10 Doug Evans * psymtab.c (map_symbol_filenames_psymtab): Skip shared psymtabs. Index: psymtab.c =================================================================== RCS file: /cvs/src/src/gdb/psymtab.c,v retrieving revision 1.50 diff -u -p -r1.50 psymtab.c --- psymtab.c 10 Jul 2012 20:17:30 -0000 1.50 +++ psymtab.c 10 Jul 2012 20:53:14 -0000 @@ -1159,6 +1159,11 @@ map_symbol_filenames_psymtab (struct obj if (ps->readin) continue; + /* We can skip shared psymtabs here, because any file name will be + attached to the unshared psymtab. */ + if (ps->user != NULL) + continue; + /* Anonymous psymtabs don't have a file name. */ if (ps->anonymous) continue;