From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: GDB Administrator <gdbadmin@sourceware.org>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Sun Jul 8 01:55:37 UTC 2012
Date: Sun, 08 Jul 2012 08:53:00 -0000 [thread overview]
Message-ID: <20120708085302.GA4153@host2.jankratochvil.net> (raw)
In-Reply-To: <20120708015538.GA10693@sourceware.org>
On Sun, 08 Jul 2012 03:55:38 +0200, GDB Administrator wrote:
> 173a174,178
> > gdb/common/linux-ptrace.c:60: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/linux-ptrace.c:60:#include <sys/wait.h>
For gdbserver it would:
../common/linux-ptrace.c:57:22: fatal error: gdb_wait.h: No such file or directory
> > gdb/common/linux-ptrace.c:82: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:82: strerror (errno));
> > gdb/common/linux-ptrace.c:94: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:94: strerror (errno));
> > gdb/common/linux-ptrace.c:101: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:101: strerror (errno));
> > gdb/common/linux-ptrace.c:129: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:129: strerror (errno));
safe_strerror has the same problem for gdbserver.
As this is all in Linux-only and even i386-only code I find it both safe.
glibc both accepts NULL for %s and produces "Unknown error 324234234" for
invalid errno. Also errno is there only the system produced one.
I am not aware of non-glibc libcs behavior but it should not be problem.
Regards,
Jan
next prev parent reply other threads:[~2012-07-08 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 1:56 GDB Administrator
2012-07-08 8:53 ` Jan Kratochvil [this message]
2012-07-25 15:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120708085302.GA4153@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gdbadmin@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox