From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6524 invoked by alias); 8 Jul 2012 08:53:23 -0000 Received: (qmail 6514 invoked by uid 22791); 8 Jul 2012 08:53:22 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 08 Jul 2012 08:53:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q688r7WG015667 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 8 Jul 2012 04:53:07 -0400 Received: from host2.jankratochvil.net (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q688r2EL032481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 8 Jul 2012 04:53:05 -0400 Date: Sun, 08 Jul 2012 08:53:00 -0000 From: Jan Kratochvil To: GDB Administrator Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Sun Jul 8 01:55:37 UTC 2012 Message-ID: <20120708085302.GA4153@host2.jankratochvil.net> References: <20120708015538.GA10693@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120708015538.GA10693@sourceware.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00108.txt.bz2 On Sun, 08 Jul 2012 03:55:38 +0200, GDB Administrator wrote: > 173a174,178 > > gdb/common/linux-ptrace.c:60: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h > gdb/common/linux-ptrace.c:60:#include For gdbserver it would: ../common/linux-ptrace.c:57:22: fatal error: gdb_wait.h: No such file or directory > > gdb/common/linux-ptrace.c:82: regression: strerror: Do not use strerror(), instead use safe_strerror() > gdb/common/linux-ptrace.c:82: strerror (errno)); > > gdb/common/linux-ptrace.c:94: regression: strerror: Do not use strerror(), instead use safe_strerror() > gdb/common/linux-ptrace.c:94: strerror (errno)); > > gdb/common/linux-ptrace.c:101: regression: strerror: Do not use strerror(), instead use safe_strerror() > gdb/common/linux-ptrace.c:101: strerror (errno)); > > gdb/common/linux-ptrace.c:129: regression: strerror: Do not use strerror(), instead use safe_strerror() > gdb/common/linux-ptrace.c:129: strerror (errno)); safe_strerror has the same problem for gdbserver. As this is all in Linux-only and even i386-only code I find it both safe. glibc both accepts NULL for %s and produces "Unknown error 324234234" for invalid errno. Also errno is there only the system produced one. I am not aware of non-glibc libcs behavior but it should not be problem. Regards, Jan