Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>,
	       Sergio Durigan <sdurigan@redhat.com>
Subject: Splint report and scripts for gdb (was: Expand bitpos and type.length)
Date: Thu, 28 Jun 2012 13:18:00 -0000	[thread overview]
Message-ID: <20120628184814.30a8977f@spoyarek> (raw)

Hi Jan,

I'm breaking this out into a new thread since I'm finding it difficult
to search for responses in the old thread due to the huge amount of
nesting. The old thread is here:

http://sourceware.org/ml/gdb-patches/2012-06/msg00635.html

I started trying to reduce the splint report further, again with a
newer approach. We're essentially looking for splint warnings that are
present after applying the bitpos patch, including those that were
newly generated and were relevant to the bitpos change, so the old
output sections (The '-' lines) are unnecessary in the report.

Based on this, I did the following:

* Modified splint-locdiff script to remove all unnecessary lines
  like 'finished checking', etc. The change is small enough that one
  can see the changes straight away.

* Removed all the '-' lines, so that what we get is only the report of
  warnings generated after bitpos.

After all the sanitization, what we have left is a very clean pattern,
which is:

LOC (file:num)
  The warning for this LOC

I used this to evaluate if the assignments, function parameters, etc.
for each of those warnings were size-compatible, i.e. they won't result
in truncation, and passed those. I don't look at sign preservation
across the patch any more because it is easier to do that from the
patch rather than the splint output.

Along with this, I have tried to make the output of the final script as
compact as possible without losing readability. The result is a final
output of 666 lines. I have uploaded the tarball here:

http://siddhesh.fedorapeople.org/splint-bitpos.tar.xz

These are the exact same files that you had uploaded earlier, so you
should be able to git-init a repository from your files and then
overwrite them with my copy to get a difference.

Can you please review the script changes?

Thanks,
Siddhesh


             reply	other threads:[~2012-06-28 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 13:18 Siddhesh Poyarekar [this message]
2012-07-01 19:38 ` Jan Kratochvil
2012-07-02  2:49   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628184814.30a8977f@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=sdurigan@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox